Show tutorial section for english only on code.org/music #58700
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hannahbergam
approved these changes
May 16, 2024
| %section | ||
| .wrapper | ||
| .flex-container.justify-space-between.align-items-center.wrap.gap-2 | ||
| %figure.col-47 |
There was a problem hiding this comment.
I take it this part changed because you're making space for the additional 'Available in English only' line?
There was a problem hiding this comment.
Correct! Adding that line made the text part taller than the image so adjusting the widths of the image and text wrapper makes the section look more balanced and easier to read.
There was a problem hiding this comment.
My Kelby-senses are improving by the day
bethanyaconnor
approved these changes
May 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Shows the Tutorial section for English-only on https://code.org/music.
Links
Jira ticket: ACQ-1894
Slack convo: here
Testing story
Tested locally in English and French
Followup
We will show this section to all languages once the "Available in English only" string translation comes in. See followup ticket: ACQ-1895
English
French