Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump versions on code-studio mocha and mochify #7097

Closed
wants to merge 1 commit into from

Conversation

islemaster
Copy link
Contributor

mocha: ^2.3.4 to ^2.4.5
mochify: ^2.15.0 to ^2.17.0

There's an intermediate version of mocha (>2.4.0, <2.4.5) that broke compatability with PhantomJS by its use of a particular color output library, documented here: mantoni/mochify.js#129

Bumping to this version ensures we're past that bug, which is fixed in 2.4.5 (https://github.com/mochajs/mocha/blob/master/CHANGELOG.md#245--2016-01-28)

mocha: ^2.3.4 to ^2.4.5
mochify: ^2.15.0 to ^2.17.0

There's an intermediate version of mocha (>2.4.0, <2.4.5) that broke compatability with PhantomJS by its use of a particular color output library, documented here: mantoni/mochify.js#129

Bumping to this version ensures we're past that bug, which is fixed in 2.4.5 (https://github.com/mochajs/mocha/blob/master/CHANGELOG.md#245--2016-01-28)
@islemaster
Copy link
Contributor Author

Never got feedback on this and managed to fix my problem locally, so I'm going to close it as not helpful.

@islemaster islemaster closed this Apr 4, 2016
@islemaster islemaster deleted the bump-mocha-mochify branch April 4, 2016 18:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants