Font variation support #33
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey @codeAdrian, I have added support to listen for font variations like weight and style which solves #25
better handling of font listener function to fix issue mentioned here #29 (comment) for which timeout and interval values which were previously deprecated are used
You can specify a specific font variation or set of variations to
nameand watch by appending the variations separated by commas to the family name separated by a colon. Variations are specified using FVD notation.example:
name: 'roboto:n1,n3'and the class added will be
class="wf-roboto-n1 wf-roboto-n3 wf-all"These changes are breaking changes but to make them non-breaking if only font name is passed i.e
name: 'roboto'then appended class name will beclass="wf-roboto wf-all"ref. https://github.com/typekit/webfontloader