bump puppeteer version to v3.0 #2342
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elukoyanov
reviewed
Apr 16, 2020
test/helper/webapi.js
Outdated
| @@ -648,7 +648,8 @@ module.exports.tests = function () { | |||
| }); | |||
| }); | |||
|
|
|||
| describe('#attachFile', () => { | |||
| describe.skip('#attachFile', () => { | |||
| // Those tests are skipped due to bug https://github.com/puppeteer/puppeteer/issues/5543 | |||
There was a problem hiding this comment.
could you mark this as // TODO: .... ?
possibly, we can create issue with this problem, to see it
and type link on it // TODO: #xxxx bla bla.... or // TODO: https://github.com/Codeception/CodeceptJS/issues/xxxx bla bla...
test/helper/Puppeteer_test.js
Outdated
| @@ -17,7 +17,9 @@ let page; | |||
| let FS; | |||
| const siteUrl = TestHelper.siteUrl(); | |||
|
|
|||
| describe('Puppeteer - BasicAuth', () => { | |||
| describe('Puppeteer - BasicAuth', function () { | |||
| this.timeout(35000); | |||
DavertMik
requested changes
Apr 17, 2020
test/helper/webapi.js
Outdated
| @@ -648,7 +648,8 @@ module.exports.tests = function () { | |||
| }); | |||
| }); | |||
|
|
|||
| describe('#attachFile', () => { | |||
| describe.skip('#attachFile', () => { | |||
There was a problem hiding this comment.
ups, this is going to skip this test for ALL helpers!
please check webapi.js there are examples how to skip tests for exactly one helper
|
Closed in favor of #2355 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation/Description of the PR
Applicable helpers:
Type of change
Checklist:
npm run docs)npm run lint)npm test)Notes: