Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: log info if a file shows up as a directory #430

Merged
merged 3 commits into from May 7, 2024
Merged

fix: log info if a file shows up as a directory #430

merged 3 commits into from May 7, 2024

Conversation

thomasrockhu-codecov
Copy link
Contributor

fixes codecov/codecov-action#1303

git ls-files will pull submodules as files, this change just logs that a file shows up as such a directory and continues on

@github-actions GitHub Actions
Copy link

github-actions bot commented May 5, 2024

❌ Failed Test Results:

Completed 666 tests with 1 failed, 665 passed and 0 skipped.

View the full list of failed tests
Test Description Failure message 
Testsuite:
api.temp.calculator.test_calculator::test_divide

Test name:
pytest
 
def
                test_divide():
                > assert Calculator.divide(1, 2) == 0.5
                E assert 1.0 == 0.5
                E + where 1.0 = <function Calculator.divide at 0x104c9eb90>(1, 2)
                E + where <function Calculator.divide at 0x104c9eb90> = Calculator.divide
                .../temp/calculator/test_calculator.py:30: AssertionError

3 similar comments
@github-actions GitHub Actions
Copy link

github-actions bot commented May 5, 2024

❌ Failed Test Results:

Completed 666 tests with 1 failed, 665 passed and 0 skipped.

View the full list of failed tests
Test Description Failure message 
Testsuite:
api.temp.calculator.test_calculator::test_divide

Test name:
pytest
 
def
                test_divide():
                > assert Calculator.divide(1, 2) == 0.5
                E assert 1.0 == 0.5
                E + where 1.0 = <function Calculator.divide at 0x104c9eb90>(1, 2)
                E + where <function Calculator.divide at 0x104c9eb90> = Calculator.divide
                .../temp/calculator/test_calculator.py:30: AssertionError

@github-actions GitHub Actions
Copy link

github-actions bot commented May 5, 2024

❌ Failed Test Results:

Completed 666 tests with 1 failed, 665 passed and 0 skipped.

View the full list of failed tests
Test Description Failure message 
Testsuite:
api.temp.calculator.test_calculator::test_divide

Test name:
pytest
 
def
                test_divide():
                > assert Calculator.divide(1, 2) == 0.5
                E assert 1.0 == 0.5
                E + where 1.0 = <function Calculator.divide at 0x104c9eb90>(1, 2)
                E + where <function Calculator.divide at 0x104c9eb90> = Calculator.divide
                .../temp/calculator/test_calculator.py:30: AssertionError

@github-actions GitHub Actions
Copy link

github-actions bot commented May 5, 2024

❌ Failed Test Results:

Completed 666 tests with 1 failed, 665 passed and 0 skipped.

View the full list of failed tests
Test Description Failure message 
Testsuite:
api.temp.calculator.test_calculator::test_divide

Test name:
pytest
 
def
                test_divide():
                > assert Calculator.divide(1, 2) == 0.5
                E assert 1.0 == 0.5
                E + where 1.0 = <function Calculator.divide at 0x104c9eb90>(1, 2)
                E + where <function Calculator.divide at 0x104c9eb90> = Calculator.divide
                .../temp/calculator/test_calculator.py:30: AssertionError

@codecov Codecov
Copy link

codecov bot commented May 5, 2024 •
edited

Test Failures Detected: Due to failing tests, we cannot provide coverage reports at this time.

❌ Failed Test Results:

Completed 2664 tests with 4 failed, 2660 passed and 0 skipped.

View the full list of failed tests
Test Description Failure message 
Testsuite:
pytest

Test name:
api.temp.calculator.test_calculator::test_divide

Envs:
- python3.8
 
def
                test_divide():
                > assert Calculator.divide(1, 2) == 0.5
                E assert 1.0 == 0.5
                E + where 1.0 = <function Calculator.divide at 0x104c9eb90>(1, 2)
                E + where <function Calculator.divide at 0x104c9eb90> = Calculator.divide
                .../temp/calculator/test_calculator.py:30: AssertionError
 
Testsuite:
pytest

Test name:
api.temp.calculator.test_calculator::test_divide

Envs:
- python3.9
 
def
                test_divide():
                > assert Calculator.divide(1, 2) == 0.5
                E assert 1.0 == 0.5
                E + where 1.0 = <function Calculator.divide at 0x104c9eb90>(1, 2)
                E + where <function Calculator.divide at 0x104c9eb90> = Calculator.divide
                .../temp/calculator/test_calculator.py:30: AssertionError
 
Testsuite:
pytest

Test name:
api.temp.calculator.test_calculator::test_divide

Envs:
- python3.10
 
def
                test_divide():
                > assert Calculator.divide(1, 2) == 0.5
                E assert 1.0 == 0.5
                E + where 1.0 = <function Calculator.divide at 0x104c9eb90>(1, 2)
                E + where <function Calculator.divide at 0x104c9eb90> = Calculator.divide
                .../temp/calculator/test_calculator.py:30: AssertionError
 
Testsuite:
pytest

Test name:
api.temp.calculator.test_calculator::test_divide

Envs:
- python3.11
 
def
                test_divide():
                > assert Calculator.divide(1, 2) == 0.5
                E assert 1.0 == 0.5
                E + where 1.0 = <function Calculator.divide at 0x104c9eb90>(1, 2)
                E + where <function Calculator.divide at 0x104c9eb90> = Calculator.divide
                .../temp/calculator/test_calculator.py:30: AssertionError

thomasrockhu-codecov
thomasrockhu-codecov commented May 5, 2024
View reviewed changes
codecov_cli/services/upload/upload_collector.py
@@ -139,6 +139,8 @@ def _get_file_fixes(
reason=err.reason,
),
)
except IsADirectoryError as err:
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the relevant section

@github-actions GitHub Actions
Copy link

github-actions bot commented May 5, 2024

❌ Failed Test Results:

Completed 666 tests with 1 failed, 665 passed and 0 skipped.

View the full list of failed tests
Test Description Failure message 
Testsuite:
api.temp.calculator.test_calculator::test_divide

Test name:
pytest
 
def
                test_divide():
                &gt; assert Calculator.divide(1, 2) == 0.5
                E assert 1.0 == 0.5
                E + where 1.0 = &lt;function Calculator.divide at 0x104c9eb90&gt;(1, 2)
                E + where &lt;function Calculator.divide at 0x104c9eb90&gt; = Calculator.divide
                .../temp/calculator/test_calculator.py:30: AssertionError

3 similar comments
@github-actions GitHub Actions
Copy link

github-actions bot commented May 5, 2024

❌ Failed Test Results:

Completed 666 tests with 1 failed, 665 passed and 0 skipped.

View the full list of failed tests
Test Description Failure message 
Testsuite:
api.temp.calculator.test_calculator::test_divide

Test name:
pytest
 
def
                test_divide():
                &gt; assert Calculator.divide(1, 2) == 0.5
                E assert 1.0 == 0.5
                E + where 1.0 = &lt;function Calculator.divide at 0x104c9eb90&gt;(1, 2)
                E + where &lt;function Calculator.divide at 0x104c9eb90&gt; = Calculator.divide
                .../temp/calculator/test_calculator.py:30: AssertionError

@github-actions GitHub Actions
Copy link

github-actions bot commented May 5, 2024

❌ Failed Test Results:

Completed 666 tests with 1 failed, 665 passed and 0 skipped.

View the full list of failed tests
Test Description Failure message 
Testsuite:
api.temp.calculator.test_calculator::test_divide

Test name:
pytest
 
def
                test_divide():
                &gt; assert Calculator.divide(1, 2) == 0.5
                E assert 1.0 == 0.5
                E + where 1.0 = &lt;function Calculator.divide at 0x104c9eb90&gt;(1, 2)
                E + where &lt;function Calculator.divide at 0x104c9eb90&gt; = Calculator.divide
                .../temp/calculator/test_calculator.py:30: AssertionError

@github-actions GitHub Actions
Copy link

github-actions bot commented May 5, 2024

❌ Failed Test Results:

Completed 666 tests with 1 failed, 665 passed and 0 skipped.

View the full list of failed tests
Test Description Failure message 
Testsuite:
api.temp.calculator.test_calculator::test_divide

Test name:
pytest
 
def
                test_divide():
                &gt; assert Calculator.divide(1, 2) == 0.5
                E assert 1.0 == 0.5
                E + where 1.0 = &lt;function Calculator.divide at 0x104c9eb90&gt;(1, 2)
                E + where &lt;function Calculator.divide at 0x104c9eb90&gt; = Calculator.divide
                .../temp/calculator/test_calculator.py:30: AssertionError

@github-actions GitHub Actions
Copy link

github-actions bot commented May 6, 2024

❌ Failed Test Results:

Completed 666 tests with 1 failed, 665 passed and 0 skipped.

View the full list of failed tests
Test Description Failure message 
Testsuite:
api.temp.calculator.test_calculator::test_divide

Test name:
pytest
 
def
                test_divide():
                &gt; assert Calculator.divide(1, 2) == 0.5
                E assert 1.0 == 0.5
                E + where 1.0 = &lt;function Calculator.divide at 0x104c9eb90&gt;(1, 2)
                E + where &lt;function Calculator.divide at 0x104c9eb90&gt; = Calculator.divide
                .../temp/calculator/test_calculator.py:30: AssertionError

3 similar comments
@github-actions GitHub Actions
Copy link

github-actions bot commented May 6, 2024

❌ Failed Test Results:

Completed 666 tests with 1 failed, 665 passed and 0 skipped.

View the full list of failed tests
Test Description Failure message 
Testsuite:
api.temp.calculator.test_calculator::test_divide

Test name:
pytest
 
def
                test_divide():
                &gt; assert Calculator.divide(1, 2) == 0.5
                E assert 1.0 == 0.5
                E + where 1.0 = &lt;function Calculator.divide at 0x104c9eb90&gt;(1, 2)
                E + where &lt;function Calculator.divide at 0x104c9eb90&gt; = Calculator.divide
                .../temp/calculator/test_calculator.py:30: AssertionError

@github-actions GitHub Actions
Copy link

github-actions bot commented May 6, 2024

❌ Failed Test Results:

Completed 666 tests with 1 failed, 665 passed and 0 skipped.

View the full list of failed tests
Test Description Failure message 
Testsuite:
api.temp.calculator.test_calculator::test_divide

Test name:
pytest
 
def
                test_divide():
                &gt; assert Calculator.divide(1, 2) == 0.5
                E assert 1.0 == 0.5
                E + where 1.0 = &lt;function Calculator.divide at 0x104c9eb90&gt;(1, 2)
                E + where &lt;function Calculator.divide at 0x104c9eb90&gt; = Calculator.divide
                .../temp/calculator/test_calculator.py:30: AssertionError

@github-actions GitHub Actions
Copy link

github-actions bot commented May 6, 2024

❌ Failed Test Results:

Completed 666 tests with 1 failed, 665 passed and 0 skipped.

View the full list of failed tests
Test Description Failure message 
Testsuite:
api.temp.calculator.test_calculator::test_divide

Test name:
pytest
 
def
                test_divide():
                &gt; assert Calculator.divide(1, 2) == 0.5
                E assert 1.0 == 0.5
                E + where 1.0 = &lt;function Calculator.divide at 0x104c9eb90&gt;(1, 2)
                E + where &lt;function Calculator.divide at 0x104c9eb90&gt; = Calculator.divide
                .../temp/calculator/test_calculator.py:30: AssertionError

@github-actions GitHub Actions
Copy link

github-actions bot commented May 6, 2024

❌ Failed Test Results:

Completed 666 tests with 1 failed, 665 passed and 0 skipped.

View the full list of failed tests
Test Description Failure message 
Testsuite:
api.temp.calculator.test_calculator::test_divide

Test name:
pytest
 
def
                test_divide():
                &gt; assert Calculator.divide(1, 2) == 0.5
                E assert 1.0 == 0.5
                E + where 1.0 = &lt;function Calculator.divide at 0x104c9eb90&gt;(1, 2)
                E + where &lt;function Calculator.divide at 0x104c9eb90&gt; = Calculator.divide
                .../temp/calculator/test_calculator.py:30: AssertionError

3 similar comments
@github-actions GitHub Actions
Copy link

github-actions bot commented May 6, 2024

❌ Failed Test Results:

Completed 666 tests with 1 failed, 665 passed and 0 skipped.

View the full list of failed tests
Test Description Failure message 
Testsuite:
api.temp.calculator.test_calculator::test_divide

Test name:
pytest
 
def
                test_divide():
                &gt; assert Calculator.divide(1, 2) == 0.5
                E assert 1.0 == 0.5
                E + where 1.0 = &lt;function Calculator.divide at 0x104c9eb90&gt;(1, 2)
                E + where &lt;function Calculator.divide at 0x104c9eb90&gt; = Calculator.divide
                .../temp/calculator/test_calculator.py:30: AssertionError

@github-actions GitHub Actions
Copy link

github-actions bot commented May 6, 2024

❌ Failed Test Results:

Completed 666 tests with 1 failed, 665 passed and 0 skipped.

View the full list of failed tests
Test Description Failure message 
Testsuite:
api.temp.calculator.test_calculator::test_divide

Test name:
pytest
 
def
                test_divide():
                &gt; assert Calculator.divide(1, 2) == 0.5
                E assert 1.0 == 0.5
                E + where 1.0 = &lt;function Calculator.divide at 0x104c9eb90&gt;(1, 2)
                E + where &lt;function Calculator.divide at 0x104c9eb90&gt; = Calculator.divide
                .../temp/calculator/test_calculator.py:30: AssertionError

@github-actions GitHub Actions
Copy link

github-actions bot commented May 6, 2024

❌ Failed Test Results:

Completed 666 tests with 1 failed, 665 passed and 0 skipped.

View the full list of failed tests
Test Description Failure message 
Testsuite:
api.temp.calculator.test_calculator::test_divide

Test name:
pytest
 
def
                test_divide():
                &gt; assert Calculator.divide(1, 2) == 0.5
                E assert 1.0 == 0.5
                E + where 1.0 = &lt;function Calculator.divide at 0x104c9eb90&gt;(1, 2)
                E + where &lt;function Calculator.divide at 0x104c9eb90&gt; = Calculator.divide
                .../temp/calculator/test_calculator.py:30: AssertionError

giovanni-guidini
giovanni-guidini approved these changes May 7, 2024
View reviewed changes
Copy link
Contributor

@giovanni-guidini giovanni-guidini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wouldn't hurt to have a test for it, but LGTM

@thomasrockhu-codecov thomasrockhu-codecov merged commit e4b6e1c into main May 7, 2024
20 of 22 checks passed
@thomasrockhu-codecov thomasrockhu-codecov deleted the th/isadirectory-error branch May 7, 2024 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@giovanni-guidini giovanni-guidini giovanni-guidini approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[v4] Unexpected IsADirectoryError when uploading coverage
2 participants
@thomasrockhu-codecov @giovanni-guidini