ref: Move useRepoConfig off RepositoryDeprecated (#2860)

src/pages/RepoPage/ComponentsTab/subroute/ComponentsTable/ComponentsTable.spec.tsx

@@ -11,6 +11,7 @@ import ComponentsTable from './ComponentsTable'
 const mockRepoConfig = {
   owner: {
     repository: {
+      __typename: 'Repository',
       repositoryConfig: {
         indicationRange: { upperRange: 80, lowerRange: 60 },
       },

src/pages/RepoPage/CoverageTab/Summary/Summary.spec.jsx

@@ -97,10 +97,12 @@ const mockRepoCoverage = {
 }
 
 const mockRepoConfig = {
-  repositoryConfig: {
-    indicationRange: {
-      upperRange: 80,
-      lowerRange: 60,
+  owner: {
+    repository: {
+      __typename: 'Repository',
+      repositoryConfig: {
+        indicationRange: { upperRange: 80, lowerRange: 60 },
+      },
     },
   },
 }
@@ -210,10 +212,7 @@ describe('Summary', () => {
         )
       ),
       graphql.query('RepoConfig', (req, res, ctx) =>
-        res(
-          ctx.status(200),
-          ctx.data({ owner: { repository: mockRepoConfig } })
-        )
+        res(ctx.status(200), ctx.data(mockRepoConfig))
       )
     )
 

src/pages/RepoPage/CoverageTab/subroute/Sunburst/Sunburst.spec.jsx

@@ -51,9 +51,13 @@ const overviewMock = {
   },
 }
 const repoConfigMock = {
-  indicationRange: {
-    lowerRange: 60,
-    upperRange: 80,
+  owner: {
+    repository: {
+      __typename: 'Repository',
+      repositoryConfig: {
+        indicationRange: { upperRange: 80, lowerRange: 60 },
+      },
+    },
   },
 }
 

src/pages/RepoPage/FlagsTab/subroute/FlagsTable/FlagsTable.spec.tsx

@@ -18,6 +18,7 @@ import FlagsTable, { FlagTable } from './FlagsTable'
 const mockRepoConfig = {
   owner: {
     repository: {
+      __typename: 'Repository',
       repositoryConfig: {
         indicationRange: { upperRange: 80, lowerRange: 60 },
       },

src/services/pathContents/branch/dir/usePrefetchBranchDirEntry.tsx

@@ -7,7 +7,7 @@ import {
   RepoNotFoundErrorSchema,
   RepoOwnerNotActivatedErrorSchema,
 } from 'services/repo'
-import { RepoConfig } from 'services/repo/useRepoConfig'
+import { RepositoryConfigSchema } from 'services/repo/useRepoConfig'
 import Api from 'shared/api'
 import { NetworkErrorObject } from 'shared/api/helpers'
 import A from 'ui/A'
@@ -68,7 +68,7 @@ const PathContentsUnionSchema = z.discriminatedUnion('__typename', [
 
 const RepositorySchema = z.object({
   __typename: z.literal('Repository'),
-  repositoryConfig: RepoConfig,
+  repositoryConfig: RepositoryConfigSchema,
   branch: z.object({
     head: z
       .object({

src/services/pathContents/branch/dir/useRepoBranchContents.tsx

@@ -6,7 +6,7 @@ import {
   RepoNotFoundErrorSchema,
   RepoOwnerNotActivatedErrorSchema,
 } from 'services/repo'
-import { RepoConfig } from 'services/repo/useRepoConfig'
+import { RepositoryConfigSchema } from 'services/repo/useRepoConfig'
 import Api from 'shared/api'
 import { NetworkErrorObject } from 'shared/api/helpers'
 import A from 'ui/A'
@@ -71,7 +71,7 @@ export type PathContentResultType = z.infer<typeof PathContentsResultSchema>
 
 const RepositorySchema = z.object({
   __typename: z.literal('Repository'),
-  repositoryConfig: RepoConfig,
+  repositoryConfig: RepositoryConfigSchema,
   branch: z.object({
     head: z
       .object({

src/services/repo/useRepoConfig.spec.tsx

@@ -9,6 +9,7 @@ import { useRepoConfig } from './useRepoConfig'
 const mockRepoConfig = {
   owner: {
     repository: {
+      __typename: 'Repository',
       repositoryConfig: {
         indicationRange: {
           lowerRange: 60,
@@ -41,20 +42,57 @@ afterAll(() => {
   server.close()
 })
 
+interface SetupArgs {
+  isNotFoundError?: boolean
+  isOwnerNotActivatedError?: boolean
+  isUnsuccessfulParseError?: boolean
+}
+
+const mockNotFoundError = {
+  owner: {
+    repository: {
+      __typename: 'NotFoundError',
+      message: 'commit not found',
+    },
+  },
+}
+
+const mockOwnerNotActivatedError = {
+  owner: {
+    repository: {
+      __typename: 'OwnerNotActivatedError',
+      message: 'owner not activated',
+    },
+  },
+}
+
+const mockUnsuccessfulParseError = {}
+
 describe('useRepoConfig', () => {
-  function setup() {
+  function setup({
+    isNotFoundError = false,
+    isOwnerNotActivatedError = false,
+    isUnsuccessfulParseError = false,
+  }: SetupArgs) {
     server.use(
       graphql.query('RepoConfig', (req, res, ctx) => {
-        return res(ctx.status(200), ctx.data(mockRepoConfig))
+        if (isNotFoundError) {
+          return res(ctx.status(200), ctx.data(mockNotFoundError))
+        } else if (isOwnerNotActivatedError) {
+          return res(ctx.status(200), ctx.data(mockOwnerNotActivatedError))
+        } else if (isUnsuccessfulParseError) {
+          return res(ctx.status(200), ctx.data(mockUnsuccessfulParseError))
+        } else {
+          return res(ctx.status(200), ctx.data(mockRepoConfig))
+        }
       })
     )
   }
 
   describe('calling hook', () => {
-    beforeEach(() => setup())
-
     describe('no options are passed', () => {
       it('returns the repository config', async () => {
+        setup({})
         const { result } = renderHook(
           () =>
             useRepoConfig({
@@ -77,6 +115,7 @@ describe('useRepoConfig', () => {
 
     describe('options are passed', () => {
       it('returns the repository config', async () => {
+        setup({})
         const { result } = renderHook(
           () =>
             useRepoConfig({
@@ -100,4 +139,88 @@ describe('useRepoConfig', () => {
       })
     })
   })
+
+  describe('hook errors', () => {
+    beforeAll(() => {
+      console.error = () => {}
+    })
+    afterAll(() => {
+      jest.resetAllMocks()
+    })
+    it('can return unsuccessful parse error', async () => {
+      setup({ isUnsuccessfulParseError: true })
+
+      const { result } = renderHook(
+        () =>
+          useRepoConfig({
+            provider: 'gh',
+            owner: 'codecov',
+            repo: 'cool-repo',
+            opts: {
+              onSuccess: () => {},
+            },
+          }),
+        { wrapper }
+      )
+
+      await waitFor(() => expect(result.current.isError).toBeTruthy())
+      await waitFor(() =>
+        expect(result.current.error).toEqual(
+          expect.objectContaining({
+            status: 404,
+          })
+        )
+      )
+    })
+    it('can return owner not activated error', async () => {
+      setup({ isOwnerNotActivatedError: true })
+
+      const { result } = renderHook(
+        () =>
+          useRepoConfig({
+            provider: 'gh',
+            owner: 'codecov',
+            repo: 'cool-repo',
+            opts: {
+              onSuccess: () => {},
+            },
+          }),
+        { wrapper }
+      )
+
+      await waitFor(() => expect(result.current.isError).toBeTruthy())
+      await waitFor(() =>
+        expect(result.current.error).toEqual(
+          expect.objectContaining({
+            status: 403,
+          })
+        )
+      )
+    })
+    it('can return not found error', async () => {
+      setup({ isNotFoundError: true })
+
+      const { result } = renderHook(
+        () =>
+          useRepoConfig({
+            provider: 'gh',
+            owner: 'codecov',
+            repo: 'cool-repo',
+            opts: {
+              onSuccess: () => {},
+            },
+          }),
+        { wrapper }
+      )
+
+      await waitFor(() => expect(result.current.isError).toBeTruthy())
+      await waitFor(() =>
+        expect(result.current.error).toEqual(
+          expect.objectContaining({
+            status: 404,
+          })
+        )
+      )
+    })
+  })
 })