fix: remove relaxed emoji from PR comment (#419)

Signed-off-by: joseph-sentry <joseph.sawaya@sentry.io>
codecov · Apr 29, 2024 · f9f6888 · f9f6888
1 parent 02be4f5
commit f9f6888
Show file tree

Hide file tree

Showing 4 changed files with 6 additions and 8 deletions.
diff --git a/services/notification/notifiers/mixins/message/sections.py b/services/notification/notifiers/mixins/message/sections.py
@@ -104,9 +104,7 @@ class NewHeaderSectionWriter(BaseSectionWriter):
     def _possibly_include_test_result_setup_confirmation(self, comparison):
         if comparison.all_tests_passed():
             yield ("")
-            yield (
-                ":white_check_mark: All tests successful. No failed tests found :relaxed:"
-            )
+            yield (":white_check_mark: All tests successful. No failed tests found.")
 
     async def do_write_section(self, comparison, diff, changes, links, behind_by=None):
         yaml = self.current_yaml

diff --git a/services/notification/notifiers/mixins/message/writers.py b/services/notification/notifiers/mixins/message/writers.py
@@ -49,7 +49,7 @@ def header_lines(self, comparison: ComparisonProxy, diff, settings) -> List[str]
             if comparison.all_tests_passed():
                 lines.append("")
                 lines.append(
-                    ":white_check_mark: All tests successful. No failed tests found :relaxed:"
+                    ":white_check_mark: All tests successful. No failed tests found."
                 )
 
         return lines

diff --git a/services/notification/notifiers/tests/integration/test_comment.py b/services/notification/notifiers/tests/integration/test_comment.py
@@ -360,7 +360,7 @@ async def test_notify(self, sample_comparison, codecov_vcr, mock_configuration):
             "> Project coverage is 60.00%. Comparing base [(`5b174c2`)](https://app.codecov.io/gh/joseph-sentry/codecov-demo/commit/5b174c2b40d501a70c479e91025d5109b1ad5c1b?dropdown=coverage&el=desc) to head [(`5601846`)](https://app.codecov.io/gh/joseph-sentry/codecov-demo/pull/9?dropdown=coverage&src=pr&el=desc).",
             "> Report is 2 commits behind head on main.",
             "",
-            ":white_check_mark: All tests successful. No failed tests found :relaxed:",
+            ":white_check_mark: All tests successful. No failed tests found.",
             "",
             ":exclamation: Your organization needs to install the [Codecov GitHub app](https://github.com/apps/codecov/installations/select_target) to enable full functionality.",
             "",

diff --git a/services/notification/notifiers/tests/unit/test_comment.py b/services/notification/notifiers/tests/unit/test_comment.py
@@ -4053,7 +4053,7 @@ async def test_new_header_section_writer_test_results_setup(
             "All modified and coverable lines are covered by tests :white_check_mark:",
             f"> Project coverage is 0%. Comparing base [(`{sample_comparison.project_coverage_base.commit.commitid[:7]}`)](urlurl?dropdown=coverage&el=desc) to head [(`{sample_comparison.head.commit.commitid[:7]}`)](urlurl?dropdown=coverage&src=pr&el=desc).",
             "",
-            ":white_check_mark: All tests successful. No failed tests found :relaxed:",
+            ":white_check_mark: All tests successful. No failed tests found.",
         ]
 
     @pytest.mark.asyncio
@@ -4110,7 +4110,7 @@ async def test_new_header_section_writer_no_project_coverage_test_results_setup(
         assert res == [
             "All modified and coverable lines are covered by tests :white_check_mark:",
             "",
-            ":white_check_mark: All tests successful. No failed tests found :relaxed:",
+            ":white_check_mark: All tests successful. No failed tests found.",
         ]
 
 
@@ -4858,7 +4858,7 @@ async def test_build_message_team_plan_customer_all_lines_covered(
             f"## [Codecov](test.example.br/gh/{repository.slug}/pull/{pull.pullid}?dropdown=coverage&src=pr&el=h1) Report",
             "All modified and coverable lines are covered by tests :white_check_mark:",
             "",
-            ":white_check_mark: All tests successful. No failed tests found :relaxed:",
+            ":white_check_mark: All tests successful. No failed tests found.",
             "",
             ":loudspeaker: Thoughts on this report? [Let us know!](https://github.com/codecov/feedback/issues/255)",
         ]