Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed errors from development console #91

Merged
merged 3 commits into from Mar 22, 2021
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
13 changes: 5 additions & 8 deletions .storybook/main.js
@@ -1,11 +1,8 @@
module.exports = {
"stories": [
"../src/**/*.stories.mdx",
"../src/**/*.stories.@(js|jsx|ts|tsx)"
],
"addons": [
stories: ["../src/**/*.stories.mdx", "../src/**/*.stories.@(js|jsx|ts|tsx)"],
addons: [
"@storybook/addon-links",
"@storybook/addon-essentials",
"@storybook/preset-create-react-app"
]
}
"@storybook/preset-create-react-app",
],
};
3 changes: 1 addition & 2 deletions .storybook/preview.js
@@ -1,4 +1,3 @@

export const parameters = {
actions: { argTypesRegex: "^on[A-Z].*" },
}
};
2 changes: 1 addition & 1 deletion README.md
Expand Up @@ -144,8 +144,8 @@ Skip the yarn part and proceed to the Pushing the changes section [here](#-pushi
Your app is ready to be deployed!
5. See the section about [deployment](https://facebook.github.io/create-react-app/docs/deployment) for more information.


### 🚩 Running storybook :

1. Run the command `npm run storybook`
2. wait on `localhost:6000`
3. write stories for component in `stories` folder under `src` folder.
Expand Down
6 changes: 1 addition & 5 deletions src/pages/CoursePageViewWithVideo/index.js
Expand Up @@ -108,11 +108,7 @@ function TabPanel(props) {
aria-labelledby={`full-width-tab-${index}`}
{...other}
>
{value === index && (
<Box>
<Typography>{children}</Typography>
</Box>
)}
{value === index && <Box>{children}</Box>}
</div>
);
}
5 changes: 3 additions & 2 deletions src/theme/index.js
@@ -1,7 +1,8 @@
import _ from "lodash";
import { colors, createMuiTheme, responsiveFontSizes } from "@material-ui/core";
import typography from "./typography";
import { softShadows } from "./shadows";
//! Adds a error Material-UI: This elevation `4` is not implemented.
// import { softShadows } from "./shadows";
rizwan2000rm marked this conversation as resolved.
Show resolved Hide resolved

const baseConfig = {
direction: "ltr",
Expand Down Expand Up @@ -60,7 +61,7 @@ const themeConfig = {
secondary: colors.blueGrey[600],
},
},
shadows: softShadows,
// shadows: softShadows,
};

const createTheme = () => {
Expand Down