Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Call testcaseDone after failed assertion #15

Conversation

Naktibalda
Copy link
Contributor

This change makes Mocha finish testcase immediately after failed assertion.
Jasmine had no such issue and is not affected by this change (output stays the same).

Please tell me if there are any side effects caused by not calling calling failCb.

Fixes #14

@codeforequity-at
Copy link
Owner

I recognize the problem, but I think this is not a good solution, as it makes testmybot less portable for other testing frameworks (and jasmine adapter requires some changes too).
I think the better way to solve this would be here.
have to give some thought about the mocha vs jasmine differences here - while jasmine has a global "fail" function, mocha handels test cases failure with a test case specific callback.

@Naktibalda
Copy link
Contributor Author

I don't see a way to call done callback in failCb.
Relevant discussions: chaijs/chai#586 mochajs/mocha#1128

@Naktibalda Naktibalda changed the title Call testcaseDone after after assertion Call testcaseDone after failed assertion Aug 30, 2017
@codeforequity-at
Copy link
Owner

Solved with latest commit! Thanks for your input!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants