Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

URL to app and better error catch #686

Merged
merged 12 commits into from
Feb 27, 2024
Merged

URL to app and better error catch #686

merged 12 commits into from
Feb 27, 2024

Conversation

lrochette
Copy link
Contributor

What

  • Move the creation of the link to the application earlier
  • Exit with error when app is in OUT_OF_SYNC state
  • Intercepting application not found for better error message for user

Why

Customer requests

Notes

@lrochette
[FT-185] Move creation of link to app earlier in process
3f3d67c 
Signed-off-by: Laurent Rochette <laurent.rochette@codefresh.io>
@lrochette
[FT-185] 1.4.3 Move creation of link to app earlier in process
ef7ac6a 
Signed-off-by: Laurent Rochette <laurent.rochette@codefresh.io>
@lrochette
Exit with error when app is out of sync
237569c
@lrochette
Exit with error when app is in OUT_OF_SYNC state
f98f572
@lrochette
Fix variable name and misspelling
bc21b23
@lrochette
change status into health
a560eb2
@lrochette
Fix syntax errors
58a265e 
Signed-off-by: Laurent Rochette <laurent.rochette@codefresh.io>
@lrochette
V1.4.3: intercepting application not found for better error message
85da65a 
Signed-off-by: Laurent Rochette <laurent.rochette@codefresh.io>
@lrochette
V1.4.3: intercepting application not found for better error message
bced858 
Signed-off-by: Laurent Rochette <laurent.rochette@codefresh.io>
@lrochette lrochette changed the title Lr sync url URL to app and better error catch Feb 23, 2024
@lrochette lrochette merged commit 0e787b6 into master Feb 27, 2024
6 checks passed
@lrochette lrochette deleted the lr-sync-url branch February 27, 2024 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yaroslav-codefresh yaroslav-codefresh yaroslav-codefresh approved these changes

@dustinvanbuskirk dustinvanbuskirk Awaiting requested review from dustinvanbuskirk

@francisco-cocozza francisco-cocozza Awaiting requested review from francisco-cocozza

@pasha-codefresh pasha-codefresh Awaiting requested review from pasha-codefresh

@eti-codefresh eti-codefresh Awaiting requested review from eti-codefresh

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@lrochette @yaroslav-codefresh