Prevent sync operation for app in auto-sync mode #687
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Laurent Rochette <laurent.rochette@codefresh.io>
lrochette
requested review from
francisco-cocozza,
pasha-codefresh,
yaroslav-codefresh and
eti-codefresh
Signed-off-by: Laurent Rochette <laurent.rochette@codefresh.io>
| print(f"ERROR application {APPLICATION} does not seem to exist") | ||
| sys.exit(3) | ||
|
|
||
| if application_autosync(ingress_host) == False: |
There was a problem hiding this comment.
no need to do another request, check autosync while checking existance
There was a problem hiding this comment.
agreed, I will refactor later as I need another call to check current sync status
xeonalex
approved these changes
Mar 15, 2024
oleksandr-codefresh
approved these changes
Mar 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Do not proceed with the sync action if an app is in auto-sync mode
Check for app existence before doing anything
Why
Create some conflict
Notes