Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(footer): add missing classes.operatorLogo #231

Merged
merged 2 commits into from Feb 1, 2024
Merged

fix(footer): add missing classes.operatorLogo #231

merged 2 commits into from Feb 1, 2024

Conversation

revolunet
Copy link
Collaborator

@revolunet revolunet commented Feb 1, 2024

add a classes.operatorLogo for the footer and use classes.logo for the main logo.

the goal is to be able to apply a custom class to the main logo

This will be a breaking change for those using classes.logo for the operatorLogo

Not sure if this was intended or not

@revolunet revolunet changed the title fix(footer): add missing class fix(footer): add missing classes.operatorLogo Feb 1, 2024
Copy link
Collaborator

@garronej garronej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, you are fully correct. This was a bug, thank you for the PR!

src/Footer.tsx Outdated Show resolved Hide resolved
Signed-off-by: Joseph Garrone <joseph.garrone.gj@gmail.com>
@garronej garronej merged commit 4e5327a into main Feb 1, 2024
6 checks passed
@garronej garronej deleted the footer-fix branch February 1, 2024 02:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants