Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Exception rework #8728

Merged
merged 32 commits into from
May 23, 2024
Merged

fix: Exception rework #8728

merged 32 commits into from
May 23, 2024

Conversation

kenjis
Copy link
Member

@kenjis kenjis commented Apr 7, 2024 •
edited

Description
Supersedes #8470
Closes #4358

  • add new Exception classes in CodeIgniter\Exceptions
    • LogicException
    • RuntimeException
    • BadFunctionCallException
    • BadMethodCallException
    • InvalidArgumentException
  • add domain-level ExceptionInterface to catch all Exceptions in the domain
    • Files
    • HTTP
    • Router

exceptions-database-class-dia

  • all Exception classes that the framework throws
    • implement CodeIgniter\Exceptions\ExceptionInterface
    • extend \Exception (not \Error)
    • extend \LogicException or \RuntimeException

exceptions-class-dia

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@kenjis kenjis added the 4.6 label Apr 7, 2024
@kenjis kenjis changed the base branch from develop to 4.6 April 7, 2024 23:38
@kenjis kenjis changed the title Exception rework 4.6 fix: Exception rework Apr 7, 2024
@kenjis kenjis marked this pull request as draft April 7, 2024 23:39
@kenjis kenjis added bug Verified issues on the current code behavior or pull requests that will fix them breaking change Pull requests that may break existing functionalities enhancement PRs that improve existing functionalities docs needed Pull requests needing documentation write-ups and/or revisions. labels Apr 7, 2024
@MGatner
Copy link
Member

MGatner commented Apr 10, 2024

Looks good to me.

@kenjis kenjis force-pushed the exception-rework-4.6 branch 2 times, most recently from 5d7c14c to f3cb449 Compare April 16, 2024 03:10
@kenjis kenjis removed the docs needed Pull requests needing documentation write-ups and/or revisions. label Apr 16, 2024
@kenjis kenjis marked this pull request as ready for review April 16, 2024 04:44
@kenjis
Copy link
Member Author

kenjis commented Apr 16, 2024

Updated code and added user guide.

@kenjis kenjis force-pushed the exception-rework-4.6 branch 2 times, most recently from 1225408 to aba67c4 Compare April 16, 2024 09:10
@github-actions github-actions bot added the stale Pull requests with conflicts label Apr 18, 2024
@github-actions GitHub Actions
Copy link

👋 Hi, @kenjis!

We detected conflicts in your PR against the base branch 🙊
You may want to sync 🔄 your branch with upstream!

Ref: Syncing Your Branch

@kenjis kenjis removed the stale Pull requests with conflicts label Apr 18, 2024
@kenjis kenjis mentioned this pull request Apr 19, 2024
Closed
@github-actions GitHub Actions
Copy link

github-actions bot commented May 5, 2024

👋 Hi, @kenjis!

We detected conflicts in your PR against the base branch 🙊
You may want to sync 🔄 your branch with upstream!

Ref: Syncing Your Branch

@github-actions github-actions bot added the stale Pull requests with conflicts label May 5, 2024
@kenjis kenjis removed the stale Pull requests with conflicts label May 6, 2024
kenjis added 23 commits May 6, 2024 19:19
@kenjis
refactor: use CodeIgniter\Exceptions\InvalidArgumentException
049fb2b
@kenjis
refactor: use CodeIgniter\Exceptions\LogicException
4b8a50e
@kenjis
refactor: use CodeIgniter\Exceptions\BadMethodCallException
13106b8
@kenjis
refactor: use CodeIgniter\Exceptions\BadFunctionCallException
82eaa32
@kenjis
fix: replace \Exception with RuntimeException
3fa8a26
@kenjis
fix: replace \Exception with BadMethodCallException
3a35769
@kenjis
fix: replace \TypeError with InvalidArgumentException
d33d3c7
@kenjis
docs: fix class Doc comments
08fea02
@kenjis
test: update expectException()
616e0f5
@kenjis
refactor: remove unneeded implements ExceptionInterface
832c77f
@kenjis
feat: add domain-level ExceptionInterface
b91b905 
If there are more than one Exception class in the domain,
provide a domain-level interface for capture of all exceptions.
@kenjis
feat: implements domain-level ExceptionInterface
cff68f1
@kenjis
refactor: use CodeIgniter\Exceptions\InvalidArgumentException
fa0fea5
@kenjis
test: use odeIgniter\Exceptions\RuntimeException
8e75308
@kenjis
test: use CodeIgniter\Exceptions\InvalidArgumentException
8de2d70
@kenjis
test: use CodeIgniter\Exceptions\LogicException
29b8597
@kenjis
test: use CodeIgniter\Exceptions\BadMethodCallException
aae19e6
@kenjis
test: use narrower exceptions
ac9a716
@kenjis
refactor: use CodeIgniter\Exceptions\InvalidArgumentException
afe9968
@kenjis
refactor: use CodeIgniter\Exceptions\RuntimeException
5512815
@kenjis
refactor: use CodeIgniter\Exceptions\RuntimeException
99e2ba3
@kenjis
refactor: use CodeIgniter\Exceptions\InvalidArgumentException
60fddfe
@kenjis
docs: add user guide
f1359dd
@MGatner
Copy link
Member

MGatner commented May 23, 2024

UG changes look good, thanks for the thorough coverage.

@kenjis kenjis merged commit a640e3b into codeigniter4:4.6 May 23, 2024
41 checks passed
@kenjis kenjis deleted the exception-rework-4.6 branch May 23, 2024 12:05
@kenjis
Copy link
Member Author

kenjis commented May 23, 2024

@MGatner Thanks for the review!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MGatner MGatner MGatner approved these changes

Assignees
No one assigned
Labels
4.6 breaking change Pull requests that may break existing functionalities bug Verified issues on the current code behavior or pull requests that will fix them enhancement PRs that improve existing functionalities
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@kenjis @MGatner