Declare state and view peer dependencies #12
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The user is going to need to put those into package.json themselves, whether it's by adding codemirror or @codemirror/view. As such there is no issue with those being peer dependencies.
|
I'm leaning towards, as a more general solution, to really put all @codemirror and @lezer dependencies on all these packages in both peer- and regular dependency fields (using tooling to make sure they stay in sync). Does that sound like a reasonable solution to you? I'd start, as a pilot, with this package. |
|
Sure. |
marijnh
added a commit
that referenced
this pull request
Jun 15, 2022
FIX: Declare package dependencies as peer dependencies as an attempt to avoid duplicated package issues. Issue #12 Issue codemirror/dev#858
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The user is going to need to put those into package.json themselves, whether it's by adding codemirror or @codemirror/view. As such there is no issue with those being peer dependencies.
See codemirror/dev#858.