Skip to content

Commit

Permalink
use import instead of multi-entry plugin
Browse files Browse the repository at this point in the history
  • Loading branch information
BrianHung committed Jun 17, 2020
1 parent 54f0f99 commit 2f1b789
Show file tree
Hide file tree
Showing 6 changed files with 50 additions and 48 deletions.
8 changes: 3 additions & 5 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -21,12 +21,11 @@
"lint": "bin/lint"
},
"devDependencies": {
"@rollup/plugin-buble": "^0.21.3",
"blint": "^1.1.0",
"node-static": "0.7.11",
"puppeteer": "^1.20.0",
"rollup": "^1.26.3",
"@rollup/plugin-buble": "^0.21.3",
"@rollup/plugin-multi-entry": "^3.0.1"
"rollup": "^1.26.3"
},
"bugs": "http://github.com/codemirror/CodeMirror/issues",
"keywords": [
Expand All @@ -44,6 +43,5 @@
"dependencies": {},
"devDependencies": {}
},
"dependencies": {
}
"dependencies": {}
}
9 changes: 4 additions & 5 deletions rollup.config.js
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
import buble from '@rollup/plugin-buble';
import multi from '@rollup/plugin-multi-entry';

export default [
{
Expand All @@ -21,23 +20,23 @@ export default [
plugins: [ buble({namedFunctionExpressions: false}) ]
},
{
input: ["src/addon/runmode/runmode-standalone.js", "addon/runmode/runmode.js"],
input: ["src/addon/runmode/runmode-standalone.js"],
output: {
format: "iife",
file: "addon/runmode/runmode-standalone.js",
name: "CodeMirror",
freeze: false, // IE8 doesn't support Object.freeze.
},
plugins: [ buble({namedFunctionExpressions: false}), multi() ]
plugins: [ buble({namedFunctionExpressions: false}) ]
},
{
input: ["src/addon/runmode/runmode.node.js", "addon/runmode/runmode.js"],
input: ["src/addon/runmode/runmode.node.js"],
output: {
format: "cjs",
file: "addon/runmode/runmode.node.js",
name: "CodeMirror",
freeze: false, // IE8 doesn't support Object.freeze.
},
plugins: [ buble({namedFunctionExpressions: false}), multi() ]
plugins: [ buble({namedFunctionExpressions: false}) ]
},
];
20 changes: 20 additions & 0 deletions src/addon/runmode/codemirror-standalone.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,20 @@
import StringStream from "../../util/StringStream.js"
import * as modeMethods from "../../modes.js"

// Create a minimal CodeMirror needed to use runMode, and assign to root.
var root = typeof globalThis !== 'undefined' ? globalThis : window
root.CodeMirror = {}

// Copy StringStream and mode methods into CodeMirror object.
CodeMirror.StringStream = StringStream
for (var exported in modeMethods) CodeMirror[exported] = modeMethods[exported]

// Minimal default mode.
CodeMirror.defineMode("null", () => ({token: stream => stream.skipToEnd()}))
CodeMirror.defineMIME("text/plain", "null")

CodeMirror.registerHelper = CodeMirror.registerGlobalHelper = Math.min
CodeMirror.splitLines = function(string) { return string.split(/\r?\n|\r/); }

CodeMirror.defaults = { indentUnit: 2 }
export default CodeMirror;
19 changes: 19 additions & 0 deletions src/addon/runmode/codemirror.node.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,19 @@
import StringStream from "../../util/StringStream.js"
import * as modeMethods from "../../modes.js"

// Copy StringStream and mode methods into exports (CodeMirror) object.
exports.StringStream = StringStream
for (var exported in modeMethods) exports[exported] = modeMethods[exported]

// Shim library CodeMirror with the minimal CodeMirror defined above.
require.cache[require.resolve("../../lib/codemirror")] = require.cache[require.resolve("./runmode.node")]
require.cache[require.resolve("../../addon/runmode/runmode")] = require.cache[require.resolve("./runmode.node")]

// Minimal default mode.
exports.defineMode("null", () => ({token: stream => stream.skipToEnd()}))
exports.defineMIME("text/plain", "null")

exports.registerHelper = exports.registerGlobalHelper = Math.min
exports.splitLines = function(string) { return string.split(/\r?\n|\r/); }

exports.defaults = { indentUnit: 2 }
21 changes: 2 additions & 19 deletions src/addon/runmode/runmode-standalone.js
Original file line number Diff line number Diff line change
@@ -1,19 +1,2 @@
import StringStream from "../../util/StringStream.js"
import * as modeMethods from "../../modes.js"

// Create a minimal CodeMirror needed to use runMode, and assign to root.
var root = typeof globalThis !== 'undefined' ? globalThis : window
root.CodeMirror = {}

// Copy StringStream and mode methods into CodeMirror object.
CodeMirror.StringStream = StringStream
for (var exported in modeMethods) CodeMirror[exported] = modeMethods[exported]

// Minimal default mode.
CodeMirror.defineMode("null", () => ({token: stream => stream.skipToEnd()}))
CodeMirror.defineMIME("text/plain", "null")

CodeMirror.registerHelper = CodeMirror.registerGlobalHelper = Math.min
CodeMirror.splitLines = function(string) { return string.split(/\r?\n|\r/); }

CodeMirror.defaults = { indentUnit: 2 }
import "./codemirror-standalone.js"
import "../../../addon/runmode/runmode.js"
21 changes: 2 additions & 19 deletions src/addon/runmode/runmode.node.js
Original file line number Diff line number Diff line change
@@ -1,19 +1,2 @@
import StringStream from "../../util/StringStream.js"
import * as modeMethods from "../../modes.js"

// Copy StringStream and mode methods into exports (CodeMirror) object.
exports.StringStream = StringStream
for (var exported in modeMethods) exports[exported] = modeMethods[exported]

// Shim library CodeMirror with the minimal CodeMirror defined above.
require.cache[require.resolve("../../lib/codemirror")] = require.cache[require.resolve("./runmode.node")]
require.cache[require.resolve("../../addon/runmode/runmode")] = require.cache[require.resolve("./runmode.node")]

// Minimal default mode.
exports.defineMode("null", () => ({token: stream => stream.skipToEnd()}))
exports.defineMIME("text/plain", "null")

exports.registerHelper = exports.registerGlobalHelper = Math.min
exports.splitLines = function(string) { return string.split(/\r?\n|\r/); }

exports.defaults = { indentUnit: 2 }
import "./codemirror.node.js"
import "../../../addon/runmode/runmode.js"

0 comments on commit 2f1b789

Please sign in to comment.