Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[sql-hint] identifier quote is not escaped if identifiers contain it - or spaces #4626

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

[sql-hint] identifier quote is not escaped if identifiers contain it - or spaces #4626

wants to merge 3 commits into from

Commits on Mar 2, 2017

  1. Four new test for sql-hint that currently fail because the hinter doe… 

    …s not correctly escape column identifiers in table names, column names etc. For example a table name back`tick needs to be escaped like this: `back``tick`. Same for double quotes as column identifiers.
    @crazy4chrissi
    crazy4chrissi committed Mar 2, 2017
    Configuration menu
    Copy the full SHA
    68836f4 View commit details
    Browse the repository at this point in the history

Commits on Mar 3, 2017

  1. sql-hint-test.js: more tests that currently fails because of bugs :|

    @crazy4chrissi
    crazy4chrissi committed Mar 3, 2017
    Configuration menu
    Copy the full SHA
    7664a19 View commit details
    Browse the repository at this point in the history

Commits on Mar 4, 2017

  1. sql-hint: Identifiers that contain the identifierQuote like a table n… 

    …amed my"table are now doublicated correctly (e.g. quoting produces: "my""table"). This fixes 2 failing tests, but 2 others still fail.
    @crazy4chrissi
    crazy4chrissi committed Mar 4, 2017
    Configuration menu
    Copy the full SHA
    7c87848 View commit details
    Browse the repository at this point in the history