Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adjustments for eclipse java (preview / call for help) #6016

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

adjustments for eclipse java (preview / call for help) #6016

wants to merge 1 commit into from

Conversation

sterlp
Copy link

@sterlp sterlp commented Sep 28, 2019

  • added void as keyword // so that it is like public and class
  • used correct color annotations

I haven't found a CSS class telling that it is java - please check the changes and provide advice if where is a better solution.

Open:

.cm-s-eclipse span.cm-type + span.cm-variable { color: #00f !important; }
primitive types have a wrong color too:
jQuery( ".cm-s-eclipse span.cm-type:contains('boolean')" ) .css({"color": "#7F0055", "font-weight": "bold"}); });

Result with the changes

codemirror

image

eclipse

image

Fixed

  • void has the correct color
  • boolean return type has the correct color // JS local fix

Needs work

  • Class name has still the wrong color
  • String as a primitive type as still a wrong color
  • methods have a wrong color

- added void as keyword
- used correct color annotations
@sterlp sterlp changed the title adjustments for eclipse java adjustments for eclipse java (preview / call for help) Sep 28, 2019
@marijnh
Copy link
Member

marijnh commented Sep 30, 2019

added void as keyword // so that it is like public and class

Despite what Eclipse does here, void is a type so I think highlighting it as such is reasonable.

In general, creating exactly the same highlighting as Eclipse is not a goal for this project.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants