Always render linter's tooltip inside of viewport #7044
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
What can we do about to prioritize? |
|
There is already code that does something like this in the library. Figuring out why it doesn't do what you want in this case would be the thing to do. Code that adds another layout cycle to every tooltip update, as this does, is definitely not going to be merged. |
I have adapted the implementation to only have one cycle and slightly simplified. Please adapt as you like it of course.
Fix build's linting issues
|
Please let me know if any changes needed for merge, or if I should squash. |
marijnh
added a commit
that referenced
this pull request
Jul 21, 2023
|
Attached patch simplifies this a bit and reduces the number of reflows the code causes. Does it work for you? |
|
Yes, works like a charm, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The following shows, if the linter's tooltip is exceeding the viewport:
The following shows the fixed version:
This is a very quick solution, fixing that particular corner case, shown in the screenshot.
Or course, we would appreciate a more mature solution to this problem in general.