Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename blockKeywords #4

Merged
merged 1 commit into from Mar 13, 2022
Merged

Rename blockKeywords #4

merged 1 commit into from Mar 13, 2022

Conversation

melpon
Copy link
Contributor

@melpon melpon commented Mar 12, 2022

blockKeywords is defined twice.
When using a script converted with esbuild, the first blockKeywords is deleted due to issue evanw/esbuild#2098.
To address this issue, rename the first blockKeywords definition to blockKeywordsStr.

blockKeywords is defined twice.
When using a script converted with esbuild, the first blockKeywords is deleted due to issue evanw/esbuild#2098.
To address this issue, rename the first blockKeywords definition to blockKeywordsStr.
@marijnh marijnh merged commit 48c8902 into codemirror:main Mar 13, 2022
@marijnh
Copy link
Member

marijnh commented Mar 13, 2022

On closer look, these are not even in the same scope, so this definitely sounds like an esbuild bug.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants