Implemented API 31+ vibration service code to replace depreciated code #3755
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you remove the extra files from the commit? |
|
Also please fix the compilations errors seen in the CI run. I'm guessing there's a missing import and you should use numeric values instead of constants for backward compatibility with older compilers. |
|
Yeah sorry, I have fixed the importing error and removed the unnecessary files from the PR |
|
This is still failing. I'm guessing it requires a fix to the library in the classpath but I'm not sure if this is something you can do. If not I'll have to look into it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added code that fixes the following issue:
#3702
I added retro-compatibility as well if needed.