[Bug]: Cannot find module '@node-rs/argon2-linux-arm64-gnu' #4804
Comments
benz0li
added
bug
|
@code-asher Directories in Why are there |
|
i also got these errors in 4.0.2. too many bugs after version 4.0, i have downgrade my code-server to3.12. |
|
Also the armhf build.. |
|
I have the same problem with the v4.0.2 docker image. |
|
Hmm maybe there is something wrong with the cross-compilation step. It
sets some variables that seem related to gcc...maybe we need something
similar for Rust.
|
|
I am not sure how this works actually. The |
Thanks for mentioning this. I can temporarily fix it by manually downloading |
Let me ping the node-rs team (they were super helpful when we made the migration). cc @Brooooooklyn @yisibl - is there anything obvious we might have missed in the migration? Otherwise, I'll see if I can dig in and see where this is coming form. |
@ljishen With this workaround I can build the docker image. But then, the following comes up when running the container: 👉 Directory Bottom line: I'm skipping code-server v4.0.2. |
I didn't build the image. I used the latest one from here https://hub.docker.com/r/codercom/code-server/tags $ ls /usr/lib/code-server/node_modules/@node-rs/argon2-linux-arm64-gnu
argon2.linux-arm64-gnu.node package.json README.md |
|
I have the same problem I am using Ubuntu 21.10 on my phone installed via proot-distoro how can I fix it ? |
|
FWIW, this appears to be the offending commit: 723469a I've solved it for myself by running 4.0.1, which doesn't seem to have that problem. |
|
In https://github.com/coder/code-server/pull/4733/files, I removed this: # This is due to an upstream issue with RHEL7/CentOS 7 comptability with node-argon2
# See: https://github.com/cdr/code-server/pull/3422#pullrequestreview-677765057
export npm_config_build_from_source=trueI wonder if adding it back in would fix this. I'm going to start working on this soon and will post my notes as I investigate. Thank you all for chiming in! Apologies for the issues. |
Investigation NotesThese are the notes as I investigate. I'll update this comment as not to spam this thread. Reproducing❌ Can't reproduce with issue reproduction stepsCould not reproduce with @benz0li's steps (I think they reverted back to 4.0.1).
❌ Can't reproduce with
|
|
|
|
I found a Temporary solution for this problem.
|
|
@ljishen could you provide repro steps by chance? I tried using the 4.0.2 Docker image (on macOS) but couldn't reproduce this. |
Note: I am using Ubuntu 21.10 |
I think this problem is specific to arm64 machines. So maybe you try on one of those machines. |
Ah, figured so. I don't have one sadly but currently trying to emulate one with QEMU. Not having much luck unfortunately. |
|
Okay @code-asher and I have gone down quite the rabbit hole. I'll try my best to summarize what we know. We added There doesn't appear to any solutions to our problem so the only option we have left is to revert 723469a |
|
Root cause seems to be this: npm/arborist#231 Optional dependencies are only downloaded for the current platform rather than the target platform. Long-term solution probably involves modifying that behavior in npm to use the target platform instead but in the meantime revert seems like the way to go. |
This reverts part of the changes introduced in refactor: migrate from argon2 -> @node-rs/argon2 (#4733) Switching to @node-rs/argon2 introduced bugs that we couldn't solve due to limitations in npm. see here #4804 (comment)
* revert: partial revert of 723469a This reverts part of the changes introduced in refactor: migrate from argon2 -> @node-rs/argon2 (#4733) Switching to @node-rs/argon2 introduced bugs that we couldn't solve due to limitations in npm. see here #4804 (comment)
It appears there are workarounds.
Looks like there is an open RFC discussing package distributions which might address some of these issues. |
It doesn't work on arm64 coder/code-server#4804 I don't use it enough
|
Haha I completely spaced that we use yarn not npm. |
Signed-off-by: Jeff Billimek <jeff@billimek.com>
|
Same thing happened here today |
|
@ItzMiracleOwO please wait for the next release! |
|
What's the glitch? |
wdym? |
|
You can just run this commands |
|
Same for me. |
This just threw a ton of errors. |
u need sudo |
|
Actully I tried to manually install the module but it return 404 |
|
If It requires Root administration make sure you are in a super user privileges or as root |
* revert: partial revert of 723469a This reverts part of the changes introduced in refactor: migrate from argon2 -> @node-rs/argon2 (coder#4733) Switching to @node-rs/argon2 introduced bugs that we couldn't solve due to limitations in npm. see here coder#4804 (comment)
|
@jsjoeio you can consider switch back to |
|
@Brooooooklyn That's amazing! I'm not involved in the project anymore but maybe someone else from the team/community can. Thanks for flagging! |
Is there an existing issue for this?
OS/Web Information
code-server --version: code-server 4.0.2 5cdfe74Steps to Reproduce
git clone https://gitlab.b-data.ch/jupyterlab/julia/docker-stack.gitcd docker-stack/verdocker build -t julia-ver -f latest.Dockerfile .Expected
Successful build
Actual
https://gitlab.b-data.ch/jupyterlab/r/r-ver/-/jobs/20883
Logs
Screenshot/Video
No response
Does this issue happen in VS Code?
Are you accessing code-server over HTTPS?
Notes
Related issues:
The text was updated successfully, but these errors were encountered: