Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update Node.js version to 20.x #12921

Draft
wants to merge 32 commits into
base: main
Choose a base branch
from
Draft

chore: update Node.js version to 20.x #12921

wants to merge 32 commits into from

Conversation

matifali
Copy link
Collaborator

@matifali matifali commented Apr 9, 2024

This builds fine except for a few tests. I would appreciate it if someone from @coder/eng could take this from here.

I considered this update to see dependabot failing to update as GitHub now uses Node 20.

To resolve that, why not bump to Node20, given it's the current LTS release?

Also closes #12954

@matifali matifali marked this pull request as ready for review April 13, 2024 15:37
@matifali matifali changed the title chore: update Node.js version to 20.12.1 chore: update Node.js version to 20.12.2 Apr 13, 2024
@matifali matifali changed the title chore: update Node.js version to 20.12.2 chore: update Node.js version to 20.x Apr 15, 2024
@matifali matifali marked this pull request as draft April 16, 2024 19:30
@coadler coadler removed their request for review April 16, 2024 20:00
@matifali
Copy link
Collaborator Author

THIS IS NOT URGENT AND SHOULD NOT DISTURB YOUR EXISTING INVOLVEMENTS.

@BrunoQuaresma, when you have time, would you take this over to completion and also check #12954? Thank you :)

@matifali matifali removed the request for review from aslilac April 29, 2024 16:40
@aslilac
Copy link
Member

aslilac commented May 1, 2024

looks like 22 just released. might be worth shooting straight for that if we can.

@matifali
Copy link
Collaborator Author

matifali commented May 1, 2024

Node 22 will be promoted to LTS in October and then I guess packages will take at least another few months to a year to catch up to 22.
So we have to wait at least a year.

This migration to node 20 is almost complete except 4 or 5 tests failing that I couldn't figure out.

So feel free to take it over if you want.

@aslilac

@github-actions github-actions bot added the stale This issue is like stale bread. label May 21, 2024
@matifali matifali removed the stale This issue is like stale bread. label May 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

make fmt failing on main
2 participants