feat: add validation for list(string) (#114)

* feat: add validation for list(string) * fix
coder · Mar 15, 2023 · 6fe7fc2 · 6fe7fc2
1 parent 23a23a2
commit 6fe7fc2
Show file tree

Hide file tree

Showing 2 changed files with 21 additions and 0 deletions.
diff --git a/provider/parameter.go b/provider/parameter.go
@@ -390,6 +390,12 @@ func (v *Validation) Valid(typ, value string) error {
 		if v.Monotonic != "" && v.Monotonic != ValidationMonotonicIncreasing && v.Monotonic != ValidationMonotonicDecreasing {
 			return fmt.Errorf("number monotonicity can be either %q or %q", ValidationMonotonicIncreasing, ValidationMonotonicDecreasing)
 		}
+	case "list(string)":
+		var listOfStrings []string
+		err := json.Unmarshal([]byte(value), &listOfStrings)
+		if err != nil {
+			return fmt.Errorf("value %q is not valid list of strings", value)
+		}
 	}
 	return nil
 }

diff --git a/provider/parameter_test.go b/provider/parameter_test.go
@@ -514,6 +514,19 @@ func TestValueValidatesType(t *testing.T) {
 		Min:       0,
 		Max:       2,
 		Monotonic: "decreasing",
+	}, {
+		Name:  "ValidListOfStrings",
+		Type:  "list(string)",
+		Value: `["first","second","third"]`,
+	}, {
+		Name:  "InvalidListOfStrings",
+		Type:  "list(string)",
+		Value: `["first","second","third"`,
+		Error: regexp.MustCompile("is not valid list of strings"),
+	}, {
+		Name:  "EmptyListOfStrings",
+		Type:  "list(string)",
+		Value: `[]`,
 	}} {
 		tc := tc
 		t.Run(tc.Name, func(t *testing.T) {
@@ -529,6 +542,8 @@ func TestValueValidatesType(t *testing.T) {
 			if tc.Error != nil {
 				require.Error(t, err)
 				require.True(t, tc.Error.MatchString(err.Error()), "got: %s", err.Error())
+			} else {
+				require.NoError(t, err)
 			}
 		})
 	}