feat: allow validation to be used with options
#202
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Danny Kopping <danny@coder.com>
Signed-off-by: Danny Kopping <danny@coder.com>
Signed-off-by: Danny Kopping <danny@coder.com>
Yes, the initial implementation just assumed so. I'm sure the constraint can be relaxed now. |
mtojek
reviewed
Mar 22, 2024
| } | ||
| } | ||
| ``` | ||
| 2. Run `terraform init` and observe a warning like `Warning: Provider development overrides are in effect` |
provider/parameter_test.go
Outdated
| Config: ` | ||
| data "coder_parameter" "region" { | ||
| name = "Region" | ||
| type = "number" |
There was a problem hiding this comment.
Oh weird, my editor is probably handling tabs in a strange way. Thanks 👍
provider/parameter_test.go
Outdated
| } | ||
|
|
||
| validation { | ||
| monotonic = "increasing" |
| @@ -424,6 +440,54 @@ data "coder_parameter" "region" { | |||
| require.Equal(t, expected, state.Primary.Attributes[key]) | |||
| } | |||
| }, | |||
| }, { | |||
| Name: "NumberValidation_MonotonicWithOptions", | |||
There was a problem hiding this comment.
I used to drop an example here as well.
Signed-off-by: Danny Kopping <danny@coder.com>
Signed-off-by: Danny Kopping <danny@coder.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses coder/coder#11579, PR in coder/coder will close
Currently we have a conflict declared between
optionandvalidationconfigs incoder_parameterTerraform resources (@mtojek do you have some historical context as to why that was the case?).This PR removes that conflict since there is nothing inherent in the codebase disallowing them, and we need to allow both to to accommodate the use-case mentioned in the linked issue.
I expanded the tests and added documentation for testing the provider locally.