Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(provider): coalesce arch to armv7 if on 32-bit arm #210

Merged
merged 3 commits into from
Apr 18, 2024
Merged

Conversation

johnstcn
Copy link
Member

@johnstcn johnstcn commented Apr 17, 2024

Fixes coder/coder#11782

Tested on rpi 2b / armv7

@johnstcn johnstcn self-assigned this Apr 17, 2024
@johnstcn johnstcn marked this pull request as ready for review April 17, 2024 17:20
@johnstcn johnstcn requested a review from mtojek April 17, 2024 17:20
Use this resource to associate an instance ID with an agent for zero-trust authentication. This association is done automatically for "googlecomputeinstance", "awsinstance", "azurermlinuxvirtualmachine", and "azurermwindowsvirtual_machine" resources.
Use this resource to associate an instance ID with an agent for zero-trust authentication. This association is done automatically for "google_compute_instance", "aws_instance", "azurerm_linux_virtual_machine", and "azurerm_windows_virtual_machine" resources.
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

review: make gen changed this

Copy link
Member

@mtojek mtojek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job 👍

@johnstcn johnstcn merged commit b94b7ea into main Apr 18, 2024
11 checks passed
@johnstcn johnstcn deleted the cj/armv7 branch April 18, 2024 10:28
@github-actions github-actions bot locked and limited conversation to collaborators Apr 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

arch returned by coder_provisioner and what coder_agent expects don't match
2 participants