Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

do an automatic reload when ckeditor has not been loaded. #25

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

dan753722
Copy link

We found this issue when using react-ckeditor-component in our app.

When browser first visits our page, with no cache etc. ckeditor doesn't gets rendered. We can see this error in the console: CKEditor Uncaught TypeError: Cannot call method 'unselectable' of null.

Not sure why, however, it feels like ckeditor throws that error during its editor instance initialization.

You can very reliably reproduce this issue in Internet Explorer 11, by clearing browser history.

My current solution is to have a 3-second delayed check on the editorinstance and if the editor ui failed to initialize after 3 seconds. we false loadscript process again. Only this time, ckeditor.js is loaded already in the dom.

@codeslayer1
Copy link
Owner

Not merging it for now because this does not seem to be a permanent fix. Re-initialising after 3 seconds may not suit everyone's needs. Will look into this later.

@flameddd
Copy link

flameddd commented Mar 21, 2018

suggest anyone who face this problem. set a loading status for you container and render <CKeditor /> after loading complete. I think it work for many case (for now).

@codeslayer1
Copy link
Owner

@dan753722 @flameddd Can you guys please test this fix by @R0nd - #29. Will merge the pull request if this fixes the issue.

@R0nd
Copy link
Contributor

R0nd commented Mar 30, 2018

I published the fork with fixes to npm as r0nd_react-ckeditor-component if anyone wants to try it.

@hafeezpk
Copy link

hafeezpk commented Aug 7, 2018

Seeing this issue even with r0nd_react-ckeditor-component.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants