Feature exception handling #56
Conversation
The First Version of the EH is running. A Throw-Statement is now seen as an subexit. The PPT will be written. and the Dtrace will be Written. [Chicory] Exception Handling version 2 If the exceptionHandling-Parameter is set, every Method is encapsulated by an TryCatch-Instruction. Is the exceptionHandling-Parameter not set, only a Throw-Statement writes an Throw in the DTrace. Is the exceptionHandling-Parameter set, every Throw-Statement is only recognized as an Throws in DTrace [Chicory] Exception Handling version 3 If the exceptionHandling-Parameter is set, every Method is encapsulated by an TryCatch-Instruction. Chicory now differentiate between thrown and forwarded Exceptions. Every throw-command results in a distinct PPT. [Chicory] Exception Handling version 4 Chicory calculates now a new Stackmap table entry for the EH-TryCatch jump instead adding a predefined Entry + Changed the Version Number of Daikon [xceptonHandle] make some cleaning and Forking [Chicory] Update to BCEL6 Update Exception-Handling-support to use BCEL After Rebase to newer Version removed wrong comment [Chicory] Exception Handling version 5 changed the type of the internal variable of the exception from java/lang/Exception to java/lang/Throwable. After failing the DataStructures.CursorList-Test. The synchronized-support is now compiling again. working with Exception-Handling??? synchronized is throwing an Exception in bytecode but ?? [Chicory] Exception Handling version 6 Added filter functionality to throw(.*)-PPTs rebase to master chicory Fix some merging bugs
New PPT-Suffix added (THROW,THROWS, THROWCOMBINED) Daikon know works with THROW/THROWS and combinedThrow PPTs. rebase to master daikon Fix some merging bugs like formatting
The Annotater know print the combined throw-PPT as exceptional_behaviour-block in JML the params of a method a now be printed out in JML rebase to master annotate Fix some merging bugs like formatting
Modified the goals of the chicory-tests to include Throw*-PPTs + Modified the jml-goals of the Daikon purity-test to contain parameters in method-calls
suppress the exception handle output in the tests
Rebase missed sth
Added support for catching delegated Exceptions in constructors
…d/daikon into FeatureExceptionHandling
Updated daikon.AnnotateNullable to identify Throw-PPTs
Update existing Tests to include THROW-PPTs
README
Outdated
| @@ -1,14 +0,0 @@ | |||
| This is the distribution of the Daikon invariant detector, | |||
There was a problem hiding this comment.
Why has the README file been removed?
If you propose to do so, then I would prefer such changes to appear in a separate pull request, not mixed in with the exception-handling feature.
|
According to Github, "This branch has conflicts that must be resolved". Can you please merge master into your branch and resolve the conflicts? |
java/daikon/Daikon.java
Outdated
| @@ -87,8 +87,8 @@ private Daikon() { | |||
|
|
|||
| // Don't change the order of the modifiers on these strings as they | |||
| // are automatically updated as part of the release process | |||
| public final static String release_version = "5.3.3"; | |||
| public final static String release_date = "May 2, 2016"; | |||
| public final static String release_version = "5.3.3.2_rar"; | |||
There was a problem hiding this comment.
This change should not be merged into master.
|
This important new feature needs to be documented in the user manual. There might also be some updates to be made to the developer manual. That documentation will indicate what the code is intended to do and will make the review of the code much easier than if the reviewers have to guess the intention. When you update the user manual, please don't forget to add your name to section 10.4, to give you credit for your work. Thanks! |
|
I merged the branches and fixed your comments. |
|
Thank you! |
|
This pull request is against a very old version of Daikon. Can you please merge upstream into the pull request? |
doc/daikon.texinfo
Outdated
| @@ -9185,7 +9196,7 @@ Matthew Tschantz, | |||
| Iuliu Vasilescu, | |||
| Chen Xiao, | |||
| Tao Xie, | |||
| Jeff Yuan. | |||
There was a problem hiding this comment.
Why was the punctuation removed from the end of the last sentence?
|
Superseded by #91 |
I implemented with this commits the exception handling Feature.
How we did it.
First we create for each occurrence of the throw-command a PPT, in the same way daikon does it for returns.
The PPTs are from ppt-type subexit and the suffix is :::THROWNN.
With the parameter --exception-handling we can enable the delegated Exceptions support, the throw-command is always active.
We catch the delegated exceptions by encapsulate the whole method-body with an try- block with one
handle-block at the end of the method. For every throw-command in the method, we interrupt the try-block by creating multiple try-blocks all with the same handle-block. In the handle-block we create a PPT with the suffix :::THROWS also from ppt-type subexit, which collect all uncaught ecxceptions of this method.
Daikon then combines all :::THROW*-PPTs to a new :::THROWSCOMBINED-PPT from ppt-type exit.
The Annotater then prints the :::THROWSCOMBINED-PPT as the exceptional_bahavior-block.
It turned out, it works pretty good.
Also the AnnotateNullable-tool works with exception handling.
This approach has one failure.
is an exception thrown in an try-catch block, the method logs two 3 PPTs. Enter-PPT, THROW-PPT and EXIT-PPT.
I changed the Instrument-class, added testcases in chicory-tests and daikon-test/ExceptionHandling and the Annotate-tool.