Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove the grave accent (`) from the default word regex #2983

Merged
merged 2 commits into from
Aug 7, 2023
Merged

Remove the grave accent (`) from the default word regex #2983

merged 2 commits into from
Aug 7, 2023

Commits on Aug 2, 2023

  1. Demonstrate parsing issue with backtick U+0060 (`) 

    We miss misspellings inside Markdown backticks or grave accents U+0060 (`)
because the backticks are part of the word.
    @DimitriPapadopoulos
    DimitriPapadopoulos committed Aug 2, 2023
    Configuration menu
    Copy the full SHA
    22a2e9e View commit details
    Browse the repository at this point in the history

  2. Remove the backtick U+0060 (`) from the default word regex 

    Catching typos that contain a backtick or grave accent (`) is a niche.
I bet we miss more typos inside backticks in Markdown files than we
detect typos containing a backtick.

Additionally, this restores compliance with the documentation:
	By default any alphanumeric character, the
	underscore, the hyphen, and the apostrophe is
	used to build words. This option cannot be
	specified together with --write-changes."

Use plural in the above help message:
	is → are
    @DimitriPapadopoulos
    DimitriPapadopoulos committed Aug 2, 2023
    Configuration menu
    Copy the full SHA
    57910f4 View commit details
    Browse the repository at this point in the history