Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support default sort parameters for WFS 1.1.0 sources. #6741

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

glenhein
Copy link
Contributor

@glenhein glenhein commented Jun 2, 2023

What does this PR do?

Support default sort parameters for WFS 1.1.0 sources.

Will add a response property listing the sort property name if it was removed as being unsupported.

Screen Shot 2023-06-05 at 9 02 06 AM

Who is reviewing it?

@derekwilhelm
@jlcsmith

How should this be tested?

Configure a WFS source that does not support RELEVANCE. Leave the default sort property and default sort order blank in the config. Confirm that a search that sorts by RELEVANCE returns unsorted results. Change the config to use "name" and "ASCENDING" for the default property and order. Confirm that a search that sorts by RELEVANCE returns results sorted by name.

Any background context you want to provide?

What are the relevant tickets?

Fixes: #____

Screenshots

Checklist:

  • Documentation Updated
  • Update / Add Threat Dragon models
  • Update / Add Unit Tests
  • Update / Add Integration Tests

Notes on Review Process

Please see Notes on Review Process for further guidance on requirements for merging and abbreviated reviews.

Review Comment Legend:

  • ✏️ (Pencil) This comment is a nitpick or style suggestion, no action required for approval. This comment should provide a suggestion either as an in line code snippet or a gist.
  • ❓ (Question Mark) This comment is to gain a clearer understanding of design or code choices, clarification is required but action may not be necessary for approval.
  • ❗ (Exclamation Mark) This comment is critical and requires clarification or action before approval.

@cxddfbot
Copy link

cxddfbot commented Jun 7, 2023

Internal build has been started, your results will be available at build completion.

@cxddfbot
Copy link

cxddfbot commented Jun 7, 2023

Build SUCCESS See the job results in legacy Jenkins UI or in Blue Ocean UI.

@stale
Copy link

stale bot commented Aug 12, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs within 7 days. Thank you for your contributions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants