Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DDF-6704 improve query logging #6746

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

glenhein
Copy link
Contributor

@glenhein glenhein commented Jun 7, 2023

What does this PR do?

Forward port of #6717 and #6705

Who is reviewing it?

Select relevant component teams:

Ask 2 committers to review/merge the PR and tag them here.

How should this be tested?

Any background context you want to provide?

What are the relevant tickets?

Fixes: #____

Screenshots

Checklist:

  • Documentation Updated
  • Update / Add Threat Dragon models
  • Update / Add Unit Tests
  • Update / Add Integration Tests

Notes on Review Process

Please see Notes on Review Process for further guidance on requirements for merging and abbreviated reviews.

Review Comment Legend:

  • ✏️ (Pencil) This comment is a nitpick or style suggestion, no action required for approval. This comment should provide a suggestion either as an in line code snippet or a gist.
  • ❓ (Question Mark) This comment is to gain a clearer understanding of design or code choices, clarification is required but action may not be necessary for approval.
  • ❗ (Exclamation Mark) This comment is critical and requires clarification or action before approval.

Copy link
Contributor

@jrnorth jrnorth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but we should add time units to the log messages.

@glenhein glenhein changed the title DDF-6704 improve query logging master DDF-6704 improve query logging Jun 8, 2023
@LinkMJB
Copy link
Contributor

LinkMJB commented Jul 6, 2023

build now

@cxddfbot
Copy link

cxddfbot commented Jul 6, 2023

Internal build has been started, your results will be available at build completion.

@cxddfbot
Copy link

cxddfbot commented Jul 6, 2023

Build SUCCESS See the job results in legacy Jenkins UI or in Blue Ocean UI.

@stale
Copy link

stale bot commented Sep 17, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs within 7 days. Thank you for your contributions.

@stale stale bot added the wontfix label Sep 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants