Bump to nng 1.5.2 and remove deprecated api #94
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for this PR and the recent other ones @leonardp! I'm hoping to have some time soon to check them out. Sorry for the silence up until now. |
Adds a builder class for building mbedtls and nng. Add custom build option to build nng/mbedtls (hardcoded: 'yes') Uses setup.cfg to specify the repo url and revision
For some reason pypy fails for Ubuntu and Windows, and Python 3.8 fails on Mac. While it would be better to only skip conditionally, that requires more motivation.
A new option class is added: ArbitraryOption
leonardp
force-pushed
the
remove_deprecated_api
branch
from
fc6dda5
to
ad5fb89
Compare
|
I won't have time/incentive to continue working on this in the foreseeable future. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview:
-DNNG_ELIDE_DEPRECATED=ONArbitraryOption(pub/sub which was abusingStringOptionfor this)All tests are passing without modifying anything in them.
This also includes the commit from PR #92