Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added DIRECTORY_SEPARATOR to workingDir #78

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

darthvader666uk
Copy link

THis fix is further developed from this issue:

#43

THis now appears to fix Mozart in Windows

@coenjacobs
Copy link
Owner

Hey @darthvader666uk, thanks for contributing this fix. To be honest, it doesn't sit well with me right now. This might be my bad, but I feel that the response of getcwd() can be something more than just the directory separator. In fact, for Unix based operating systems, just using the directory separator there (/) will result in Mozart using the root of the filesystem as the working directory. This will definitely lead to unwanted results.

I can imagine this being different on Windows though, where just the directory separator there (\) can be used to reference the current directory (if I recall correctly, after not having used Windows actively, for quite some time)? This might lead into a change that needs a separate bit of logic for just the Windows working directory selection. I need to properly test this in order to get it in a good enough state to merge.

szepeviktor pushed a commit to szepeviktor/BrianHenryIE_mozart that referenced this pull request Apr 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants