Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make it possible to treat non options as unknown arguments #41

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Falcosc
Copy link
Contributor

@Falcosc Falcosc commented Mar 13, 2021

No description provided.

@cofyc-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Falcosc
To complete the pull request process, please assign cofyc
You can assign the PR to them by writing /assign @cofyc in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@cofyc-bot cofyc-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Mar 13, 2021
@Falcosc
Copy link
Contributor Author

Falcosc commented Mar 13, 2021

/assign @cofyc

@cofyc
Copy link
Owner

cofyc commented Mar 14, 2021

can you describe your use case?

@Falcosc
Copy link
Contributor Author

Falcosc commented Mar 14, 2021

Projects without non option arguments do need this:

APP.exe -a 123 -b 345 invalidStuff

Or just app.exe invalid stuff

These 2 examples do currently not print help

And it needs to be a flag because projects which are using non option arguments, like a file path or an action name would like to support non option arguments. I thought the default value should be support of non option arguments, so the flag need to be manually set if you want to treat non option arguments as invalid input.

@cofyc-bot cofyc-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 14, 2021
@cofyc-bot
Copy link
Collaborator

@Falcosc: PR needs rebase.

This bot is powered by Prow and modified for my personal use.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants