Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update to latest typedoc and Typescript 4.2 #1507

Merged
merged 15 commits into from Jun 10, 2021

Conversation

larsmoa
Copy link
Contributor

@larsmoa larsmoa commented Jun 1, 2021

No description provided.

@larsmoa larsmoa requested a review from a team as a code owner June 1, 2021 22:11
@larsmoa larsmoa added the auto-update Makes bulldozer automatically update this PR when there are changes to the target branch label Jun 1, 2021
@codecov
Copy link

codecov bot commented Jun 1, 2021

Codecov Report

Merging #1507 (9903110) into master (1b8ae3a) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1507   +/-   ##
=======================================
  Coverage   68.65%   68.65%           
=======================================
  Files         136      136           
  Lines        6849     6849           
  Branches      802      802           
=======================================
  Hits         4702     4702           
  Misses       2141     2141           
  Partials        6        6           
Impacted Files Coverage Δ
viewer/src/index.ts 100.00% <ø> (ø)
viewer/src/tools.ts 0.00% <ø> (ø)

@github-actions
Copy link

github-actions bot commented Jun 1, 2021

📙 Documentation preview is available from
https://cognitedata.github.io/reveal-docs-preview/1507/docs/next/.

"exclude": ["**/*+(.spec|.test).ts"],
"excludePrivate": true,
"excludeProtected": true,
"stripInternal": true,
"excludeInternal": true,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a semantic difference here, or simply a rename?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah, reference to a doc or just common text in the PR description would be great to quickly understand the reasons behind changes 🙂

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, it's removed and picked up from tsconfig.json but I have it here to be "sure"... See TypeStrong/typedoc#1469

Copy link
Contributor

@maksnester maksnester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@maksnester maksnester merged commit 7306df2 into master Jun 10, 2021
@maksnester maksnester deleted the larsmoa/typescript-4-in-docs branch June 10, 2021 11:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-update Makes bulldozer automatically update this PR when there are changes to the target branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants