Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(react-components): remove model containers #4448

Open
wants to merge 21 commits into
base: master
Choose a base branch
from
Open

chore(react-components): remove model containers #4448

wants to merge 21 commits into from
+1,884 −1,782

Conversation

haakonflatval-cognite
Copy link
Contributor

@haakonflatval-cognite haakonflatval-cognite commented May 3, 2024 •
edited

Type of change

Chore

Jira ticket 📘

https://cognitedata.atlassian.net/browse/BND3D-4226

Description 📝

How has this been tested? 🔍

Test instructions ℹ️

Checklist ☑️

  • I am proud of this feature.
  • I have performed a self-review of my own code.
  • I have added PR type (Feat, Bug, Chore, Test, Docs, Style, Refactor) to the PR title.
  • I have manually tested this for different scenarios (different models, formats, devices, browsers).
  • I have commented my code in hard-to-understand areas.
  • I have made corresponding changes to the public documentation.
  • I have added unit and visuals tests to prove that my feature works to the best of my ability.
  • I have refactored the code for readability to the best of my ability.
  • I have checked that my changes do not introduce regressions in the public documentation.
  • I have outlined any known defects / lacking capabilities in the contents of this PR.
  • I have listed any remaining work that should follow this PR in the description or jira/miro/etc.
  • I have added TSDoc to any public facing changes.
  • I have added "developer documentation" in any package README.md that is related / applicable to this PR.
  • I have noted down and am currently tracking any technical debt introduced in this PR.
  • I have thoroughly thought about the architecture of this implementation.
  • I have asked peers to test this feature.

@haakonflatval-cognite haakonflatval-cognite marked this pull request as ready for review May 6, 2024 14:53
@haakonflatval-cognite haakonflatval-cognite requested a review from a team as a code owner May 6, 2024 14:53
pramodcog
pramodcog reviewed May 7, 2024
View reviewed changes
react-components/src/components/Reveal3DResources/Image360StylingHandler.ts
}
}

function styleAnnotation(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any reason to have this function outside the class

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

More of a personal preference - if a function doesn't need (or change) the state of a class, I put it outside. It makes it conceptually easier to reason about, since you know all its inputs. I can move it if you disagree strongly

pramodcog
pramodcog reviewed May 7, 2024
View reviewed changes
react-components/src/components/Reveal3DResources/ResourceUpdater.ts Outdated
const addedModel = await (async () => {
if (is3dModelOptions(addOptions)) {
const addedModel = await this._viewer.addModel(addOptions);
if (addedModel instanceof CogniteCadModel) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be nice to have a function isCadModel() and ìsPointCloudodel() and reuse the across react-components

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I could just create a function that uses instanceof inside, but I think it's an unnecessary abstraction. I can do it if you feel strongly about it

pramodcog
pramodcog reviewed May 7, 2024
View reviewed changes
Copy link
Contributor

@pramodcog pramodcog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some comments on first iteration, haven't yet tested it.
Will take second review!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pramodcog pramodcog pramodcog left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@haakonflatval-cognite @pramodcog