fix(react-components): remove unreferenced resources in Reveal3DResources #4481
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
haakonflatval-cognite
had a problem deploying
to
CI
GitHub Actions
Failure
haakonflatval-cognite
force-pushed
the
hflatval/remove-unreferenced-resources
branch
from
30d936a
to
6562b2c
Compare
haakonflatval-cognite
had a problem deploying
to
CI
GitHub Actions
Failure
haakonflatval-cognite
force-pushed
the
hflatval/remove-unreferenced-resources
branch
from
81b5254
to
13c5695
Compare
Aaaaaah, wasted soo much time
haakonflatval-cognite
had a problem deploying
to
CI
GitHub Actions
Failure
haakonflatval-cognite
changed the title
pramodcog
reviewed
May 15, 2024
| const addOptionsSet = new Set(addOptions); | ||
|
|
||
| return models.filter((model) => { | ||
| const correspondingAddOptions = [...addOptionsSet.values()].find((options) => { |
There was a problem hiding this comment.
[...addOptionsSet.values()] array is created every loop, we can create this array outside the loop and use it
There was a problem hiding this comment.
No, because the set changes for every iteration. I can instead use a normal Array, and search+remove from it for every iteration, but it makes the code uglier, and I don't believe it's that much more efficient
pramodcog
reviewed
May 15, 2024
| const collectionAddOptionsSet = new Set(image360CollectionAddOptions); | ||
|
|
||
| return collections.filter((collection) => { | ||
| const correspondingAddOptions = [...collectionAddOptionsSet.values()].find((options) => { |
There was a problem hiding this comment.
same here, array is created for every loop
pramodcog
reviewed
May 15, 2024
react-components/src/components/Reveal3DResources/typeGuards.ts
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Jira ticket 📘
https://cognitedata.atlassian.net/browse/
Description 📝
When e.g. the viewer is persistent across two tabs in an application, which are using different 3D resources, we never make an effort to remove the resources that are currently present in the viewer. This seeks to rectify that
How has this been tested? 🔍
Test instructions ℹ️
Checklist ☑️