Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add uuid to injected spinner style dom node to avoid race condition #4507

Merged
merged 16 commits into from
May 21, 2024
Merged

fix: add uuid to injected spinner style dom node to avoid race condition #4507

merged 16 commits into from
May 21, 2024

Conversation

nabati
Copy link
Contributor

@nabati nabati commented May 16, 2024

when using mutiple reveal instances on the same page

Type of change

Bug

Jira ticket 📘

no ticket

Thread for reference: https://cognitedata.slack.com/archives/C8A0QGMLN/p1715853617765619

Description 📝

When using multiple reveal components on a single page, if one of them unmounts then the styles would get destroyed for the other ones as well. This refactors the Spinner styleId to be an instance variable and assings a unique id to each instance.

How has this been tested? 🔍

Did not test :)

Test instructions ℹ️

Not sure :)

Checklist ☑️

  • I am proud of this feature.
  • I have performed a self-review of my own code.
  • I have added PR type (Feat, Bug, Chore, Test, Docs, Style, Refactor) to the PR title.
  • I have manually tested this for different scenarios (different models, formats, devices, browsers).
  • I have commented my code in hard-to-understand areas.
  • I have made corresponding changes to the public documentation.
  • I have added unit and visuals tests to prove that my feature works to the best of my ability.
  • I have refactored the code for readability to the best of my ability.
  • I have checked that my changes do not introduce regressions in the public documentation.
  • I have outlined any known defects / lacking capabilities in the contents of this PR.
  • I have listed any remaining work that should follow this PR in the description or jira/miro/etc.
  • I have added TSDoc to any public facing changes.
  • I have added "developer documentation" in any package README.md that is related / applicable to this PR.
  • I have noted down and am currently tracking any technical debt introduced in this PR.
  • I have thoroughly thought about the architecture of this implementation.
  • I have asked peers to test this feature.

@nabati nabati requested a review from a team as a code owner May 16, 2024 10:32
@github-actions GitHub Actions
Copy link

There were failures in the visual tests workflow.
Image diffs for visual tests can be downloaded as an artifact here.

@github-actions GitHub Actions
Copy link

There were failures in the visual tests workflow.
Image diffs for visual tests can be downloaded as an artifact here.

@christjt christjt enabled auto-merge (squash) May 21, 2024 12:51
@christjt christjt added the auto-update Makes bulldozer automatically update this PR when there are changes to the target branch label May 21, 2024
@github-actions GitHub Actions
Copy link

There were failures in the visual tests workflow.
Image diffs for visual tests can be downloaded as an artifact here.

@christjt christjt merged commit b96924c into master May 21, 2024
14 checks passed
@christjt christjt deleted the pn/add-uuid-to-spinner-styles-dom-node branch May 21, 2024 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@christjt christjt christjt approved these changes

Assignees
No one assigned
Labels
auto-update Makes bulldozer automatically update this PR when there are changes to the target branch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@nabati @christjt