Fix parsing paths containing # in FileUriMapper. #1466
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
colinrtwhite
added a commit
that referenced
this pull request
Oct 5, 2022
* Fix parsing paths containing # in FileUriMapper. * Rename test.
oguzozcan
reviewed
Nov 16, 2022
| @@ -11,7 +11,8 @@ internal class FileUriMapper : Mapper<Uri, File> { | |||
|
|
|||
| override fun map(data: Uri, options: Options): File? { | |||
| if (!isApplicable(data)) return null | |||
| return File(data.path!!) | |||
| val uri = if (data.scheme == null) data else data.buildUpon().scheme(null).build() | |||
| return File(uri.toString()) | |||
There was a problem hiding this comment.
Well that was a breaking change for us as we were previously sending local image's uri, now uri.path works, you should have document this
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #1344