Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix decoding videos inside asset subfolders. #1489

Merged
merged 1 commit into from Oct 1, 2022
Merged

Fix decoding videos inside asset subfolders. #1489

merged 1 commit into from Oct 1, 2022

Conversation

colinrtwhite
Copy link
Member

@colinrtwhite colinrtwhite commented Oct 1, 2022 •
edited

Fixes: #1482

@colinrtwhite colinrtwhite mentioned this pull request Oct 1, 2022
Closed
@colinrtwhite colinrtwhite enabled auto-merge (squash) October 1, 2022 21:40
@colinrtwhite colinrtwhite merged commit 8fc37e3 into main Oct 1, 2022
@colinrtwhite colinrtwhite deleted the colin/fix_nested_video_asset branch October 1, 2022 21:40
mhelder
mhelder reviewed Oct 4, 2022
View reviewed changes
coil-base/src/main/java/coil/decode/ImageSource.kt
message = "Migrate to filePath as it supports assets inside subfolders.",
level = DeprecationLevel.ERROR
)
val fileName: String get() = filePath.substringAfter('/')
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't this be substringAfterLast? If filePath has multiple subfolders, then substringAfter will only 'skip' the first.

Practically speaking, I guess it may not matter too much. Anyone who was using filePath before had their file located in the root of the assets folder. And for those files substringAfter and substringAfterLast will yield the same result. 🤷‍♂️

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great point! Fixed here: #1493

colinrtwhite added a commit that referenced this pull request Oct 5, 2022
@colinrtwhite
Fix decoding videos inside asset subfolders. (#1489)
4d59704
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mhelder mhelder mhelder left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

VideoFrameDecoder doesn't support videos in subfolder of Android /assets
2 participants
@colinrtwhite @mhelder