Fix decoding videos inside asset subfolders. #1489
Merged
+41
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mhelder
reviewed
Oct 4, 2022
| message = "Migrate to filePath as it supports assets inside subfolders.", | ||
| level = DeprecationLevel.ERROR | ||
| ) | ||
| val fileName: String get() = filePath.substringAfter('/') |
There was a problem hiding this comment.
Shouldn't this be substringAfterLast? If filePath has multiple subfolders, then substringAfter will only 'skip' the first.
Practically speaking, I guess it may not matter too much. Anyone who was using filePath before had their file located in the root of the assets folder. And for those files substringAfter and substringAfterLast will yield the same result. 🤷♂️
There was a problem hiding this comment.
Great point! Fixed here: #1493
colinrtwhite
added a commit
that referenced
this pull request
Oct 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #1482