Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Yarn 1.12.1 --> 1.12.3 #27

Merged
merged 1 commit into from Jan 7, 2019
Merged

Upgrade Yarn 1.12.1 --> 1.12.3 #27

merged 1 commit into from Jan 7, 2019

Conversation

jborrey
Copy link
Contributor

@jborrey jborrey commented Jan 5, 2019

This finally includes the patch for Yarn issue 6607 which was breaking lots of scans (including the current Salus scan on this PR).

@jborrey jborrey force-pushed the jborrey/upgrade-yarn branch 2 times, most recently from 9d42afc to 7209030 Compare January 5, 2019 03:45
This finally includes the patch for [Yarn issue 6607](yarnpkg/yarn#6607) which was breaking lots of scans.

Will also use a minor version bump for this since it includes the new
Yarn version and an updated version of Ruby.
@xolaz
Copy link
Contributor

xolaz commented Jan 7, 2019

based on circle build failure, it looks like yarn is still failing to run

@jborrey
Copy link
Contributor Author

jborrey commented Jan 7, 2019

Yeah - until this i merged I cannot release a new Salus. Once I do that it should pass.

If you want to check that this failure is false-positive use yarn audit (with latest yarn) locally on the branch and it should report clean.

@jborrey jborrey merged commit e00eecd into master Jan 7, 2019
@heimdall-asguard
Copy link

This Pull Request was merged without enough reviews
Please go here to review and +1

@jborrey jborrey deleted the jborrey/upgrade-yarn branch January 7, 2019 00:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants