BREAKING CHANGE: update busboy to 1.x and node 14.x #48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dead-horse
approved these changes
Sep 16, 2022
|
LGTM |
|
will realase a major version because only support node 14 now. |
dead-horse
approved these changes
Sep 16, 2022
|
2.0.0 released |
4 tasks
|
should be noted: busboy 1.x change the rule of https://github.com/mscdex/busboy/blob/master/lib/types/multipart.js#L476 vs https://github.com/mscdex/busboy/blob/v0.2.8/lib/types/multipart.js#L198 |
|
@atian25 https://github.com/eggjs/examples/tree/master/multipart-file-mode has Invalid filename
|
fengmk2
added a commit
to eggjs/egg
that referenced
this pull request
Sep 26, 2022
temp fix invalid filename cojs/busboy#48 (comment)
4 tasks
fengmk2
added a commit
to eggjs/egg
that referenced
this pull request
Sep 26, 2022
temp fix invalid filename cojs/busboy#48 (comment)
iblogc
pushed a commit
to iblogc/egg
that referenced
this pull request
Jan 9, 2023
temp fix invalid filename cojs/busboy#48 (comment)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
due to security problem: https://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2022-24434
new Busboy({})->Busboy({})onFile(fieldname, stream, filename, transferEncoding, mimeType)->onFile(name, stream, info)onField(fieldname, value, fieldnameTruncated, valueTruncated)->onField(name, value, info)related issue: eggjs/egg#4977