Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Browser theme based init #77

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

Sharkbyteprojects
Copy link

@Sharkbyteprojects Sharkbyteprojects commented Aug 17, 2021

If the user don't selected a preferred theme with the switch, the browser theme will used if available.

Description

It now save in local storage "light" or "dark", if nothing is saved, it use browser theme on init

Motivation and Context

This is only a feature request to make this better for the possibilities of the web api

How Has This Been Tested?

Manual test on:

  • Firefox
  • Edge
  • Chrome
  • Android Firefox
  • Android Chrome
  • Safari

Screenshots (if appropriate):


Types of changes

  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the code style of this project.
  • I have ran npm run test and test passes

@coliff coliff self-requested a review September 2, 2021 01:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant