Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error in regex for email validation in PR #1982 and #2058 #2267

Closed
fvckDesa opened this issue Mar 28, 2023 · 4 comments
Closed

Error in regex for email validation in PR #1982 and #2058 #2267

fvckDesa opened this issue Mar 28, 2023 · 4 comments
Labels
stale No activity in last 60 days

Comments

@fvckDesa
Copy link
Contributor

It was pointed out to me (#1982 (comment), #2154) that the regex I wrote has problems with some valid emails, I looked it again and I found the problem in the final part:

([A-Za-z0-9]([A-Za-z0-9-]*[A-Za-z0-9])*(\.[A-Za-z]{2,})+))

I got confused between domain name, subdomains and top level domain.
I also saw PR #2157 from @colinhacks who wants to make the email regex simpler so if he decides he doesn't want to change it I could fix it

@Shreyas-SAS
Copy link
Contributor

So are you willing to change it or should I work towards fixing the regex issue?

@fvckDesa
Copy link
Contributor Author

Yes, I fix it

@Shreyas-SAS
Copy link
Contributor

Yes, I fix it

oh ok. If you are confused at any step please ping me, maybe I can help with something.

@stale
Copy link

stale bot commented Jun 27, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale No activity in last 60 days label Jun 27, 2023
@fvckDesa fvckDesa closed this as completed Jul 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stale No activity in last 60 days
Projects
None yet
Development

No branches or pull requests

2 participants