[collectd 6] gpu_sysman: use base units + other metric handling fixes #4299
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reported-By: Florian Foster Signed-off-by: Eero Tamminen <eero.t.tamminen@intel.com>
Assumes overflowing counters to be either at 32-bit or 64-bit, which should cover most common cases, as long as overflow happens at max once during query period. Signed-off-by: Eero Tamminen <eero.t.tamminen@intel.com>
Signed-off-by: Eero Tamminen <eero.t.tamminen@intel.com>
With the new floating point counter type, joules & seconds can be used as metric units instead of microjoules & microseconds. (Frequencies are are still left as Mhz, but for convenience, and compability with Intel XPU Manager.) Signed-off-by: Eero Tamminen <eero.t.tamminen@intel.com>
As "write_prometheus" plugin already adds that unconditionally to names of all monotonic metric types. Signed-off-by: Eero Tamminen <eero.t.tamminen@intel.com>
This was referenced Apr 18, 2024
|
@mrunge would you have time to review this? (Florian reviewed most of these changes before I split them to their own PR, but he's not been active lately.) |
mrunge
approved these changes
May 14, 2024
Sure! Sorry for not following here much closer. |
|
No problem, I'm not in hurry with these. It's just better to get completed things reviewed before I forget their details. :-) Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ChangeLog: gpu_sysman: use base units + other metric handling fixes
This split the fixes from #4267 to their own PR (that should go in first).
Changes are IMHO straightforward and easiest to review from individual commits.
(Because switching to base units means metric names changing,
Featurelabel could have been used instead of aFixone.)