Skip to content

Commit

Permalink
bump 1.4.0
Browse files Browse the repository at this point in the history
  • Loading branch information
@rvantonder
rvantonder committed Mar 29, 2021
1 parent df1491c commit ac8ac4a
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion src/main.ml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -275,7 +275,7 @@ let parse_comby_dot_file () =

let () =
If_hack_parallel.check_entry_point ();
Command.run default_command ~version:"1.3.0" ~extend:(fun _ ->
Command.run default_command ~version:"1.4.0" ~extend:(fun _ ->
match Sys.file_exists ".comby" with
| `Yes -> parse_comby_dot_file ()
| _ -> [])

6 comments on commit ac8ac4a

@carlocab
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👋 is this your latest release? I notice that it's not showing as the latest release here on GitHub yet (which shows 1.2.1).

Just checking for Homebrew/homebrew-core#74114.

@rvantonder
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@carlocab thanks for checking. So it looks like brew picks up the the latest tags before I do a GH release. This is what I see in the releases page:

Screen Shot 2021-03-29 at 10 05 42 AM

I plan to update the releases on GH, but the timing might be a bit off (when I updated these tags it was for a different package manager release).

@carlocab
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops. It looks like we're on 1.3.0 now. Should we switch back to 1.2.1?

@rvantonder
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No I think the right thing to do here is for me to just publish a release on GH for those tags, including 1.4.0 (and the PR for Homebrew/homebrew-core#74114 is good 👍 )

@carlocab
Copy link

@carlocab carlocab commented on ac8ac4a Mar 29, 2021 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @rvantonder. That's actually a really big help. Downgrading formulae for us is rather tricky.

@rvantonder
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good! I'm going to try automate things so that the GH releases are synced with tags for future. Thanks again.

Please sign in to comment.