You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Sep 11, 2020. It is now read-only.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivated by the combination of wanting to test tryExecuteSirenAction and realising that we would just be testing timeoutPromise. We have already decided to replace exactly the same function in comit-rs (comit-network/comit-rs#2330 (comment)), so replacing it here has the nice consequence of not needing to write a new test, since it's not our own code.
Side-effects:
Move TryParams to swap.ts since it's directly related and only used for executing a swap.
Rename util/timeout_promise.ts to util/sleep.ts, since it now only holds a sleep function.
Notes
I don't believe this requires a changelog update. Am I wrong?
Motivated by the combination of wanting to test
`tryExecuteSirenAction` and realising that we would just be testing
`timeoutPromise`. We have already decided to replace exactly the same
function in
`comit-rs` (comit-network/comit-rs#2330 (comment)),
so replacing it here has the nice consequence of not needing to write
a new test, since it's not our own code.
Side-effects:
- Move `TryParams` to `swap.ts` since it's directly related and only
used for executing a swap.
- Rename `util/timeout_promise.ts` to `util/sleep.ts`, since it now
only holds a `sleep` function.
The reason will be displayed to describe this comment to others. Learn more.
Nice work!
Correct me if I'm wrong: Globally the TryParams are exported the same way?
Because we do use them in the example. If the import in the examples has to be adapted this would be a breaking change.
Nice work!
Correct me if I'm wrong: Globally the TryParams are exported the same way?
Because we do use them in the example. If the import in the examples has to be adapted this would be a breaking change.
Good point. I think it's exported the same, but I will quickly check locally.
Nice work!
Correct me if I'm wrong: Globally the TryParams are exported the same way?
Because we do use them in the example. If the import in the examples has to be adapted this would be a breaking change.
Good point. I think it's exported the same, but I will quickly check locally.
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
None yet
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #120 (imo).
Straight from the commit
Motivated by the combination of wanting to test
tryExecuteSirenActionand realising that we would just be testingtimeoutPromise. We have already decided to replace exactly the same function incomit-rs(comit-network/comit-rs#2330 (comment)), so replacing it here has the nice consequence of not needing to write a new test, since it's not our own code.Side-effects:
TryParamstoswap.tssince it's directly related and only used for executing a swap.util/timeout_promise.tstoutil/sleep.ts, since it now only holds asleepfunction.Notes
I don't believe this requires a changelog update. Am I wrong?