Disable backoffs max_elapsed_time functionality
#305
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This config setting makes backoff stop retrying if we didn't get an error within this timeframe. For us, this results in backoff not actually doing anything. The connection to kraken is very long-running. It might be active for hours without failing. However, the default value for `max_elapsed_time` is set to 15 minutes. As such, once the connection fails any time after that, backoff doesn't actually retry the operation but just gives up. Fixes #303.
da-kami
approved these changes
Mar 11, 2021
I was also very surprised by this behaviour and I am considering opening a discussion issue on backoff to remove it or at least change the default. It is not intuitive IMO. |
|
bors r+ |
rishflab
approved these changes
Mar 11, 2021
|
Opened a discussion issue on |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This config setting makes backoff stop retrying if we didn't get an
error within this timeframe.
For us, this results in backoff not actually doing anything.
The connection to kraken is very long-running. It might be active
for hours without failing. However, the default value for
max_elapsed_timeis set to 15 minutes. As such, once the connectionfails any time after that, backoff doesn't actually retry the operation
but just gives up.
Fixes #303.