Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Command.options property, and make it and Command.commands readonly #47

Merged
merged 1 commit into from Sep 13, 2023
Merged

Add Command.options property, and make it and Command.commands readonly #47

merged 1 commit into from Sep 13, 2023

Conversation

shadowspawn
Copy link
Contributor

Pull Request

Problem

Add Command.options, which was added to Commander in tj/commander.js#1827

See: #46

Solution

Simple change to match Commander.

For Commander, we landed this in a major release as could break some clients. For same reason I suggest we postpone landing this until Commander 12 (having missed it until now).

ChangeLog

  • add: add Command.options property
  • change: make Command.commands a readonly property

abetomo
abetomo approved these changes Sep 9, 2023
View reviewed changes
Copy link
Contributor

@abetomo abetomo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@shadowspawn shadowspawn changed the base branch from main to release/12.x September 13, 2023 09:32
@shadowspawn shadowspawn merged commit 6cff318 into release/12.x Sep 13, 2023
24 checks passed
@shadowspawn shadowspawn deleted the feature/add-options-property branch September 13, 2023 09:33
@shadowspawn shadowspawn added the pending release On a branch for eventual release, but not yet merged to main. label Sep 13, 2023
@shadowspawn shadowspawn added this to the 12.0.0 milestone Sep 13, 2023
@shadowspawn shadowspawn removed pending release On a branch for eventual release, but not yet merged to main. semver:major labels Oct 15, 2023
@shadowspawn
Copy link
Contributor Author

Forgot about this and have done on 11.x! #48 #50

@shadowspawn shadowspawn added pending release On a branch for eventual release, but not yet merged to main. and removed pending release On a branch for eventual release, but not yet merged to main. labels Nov 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abetomo abetomo abetomo approved these changes

@cj-christoph-gysin cj-christoph-gysin cj-christoph-gysin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
12.0.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@shadowspawn @abetomo @cj-christoph-gysin