Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing Wrong Type Information in sdk-client-v3 #621

Merged
merged 5 commits into from
Jun 5, 2024

Conversation

Engerim
Copy link
Contributor

@Engerim Engerim commented Feb 27, 2024

  • the type MiddlewareResponse states that the field is named request, but it is originalRequest
  • adjust the logger middleware to use original request field

- the type MiddlewareResponse states that the field is named request, but it is originalRequest
- adjust the logger middleware to use original request field
@Engerim Engerim requested a review from a team as a code owner February 27, 2024 09:31
Copy link

changeset-bot bot commented Feb 27, 2024

⚠️ No Changeset found

Latest commit: c78bf29

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@ajimae ajimae self-assigned this Feb 27, 2024
@Engerim
Copy link
Contributor Author

Engerim commented Jun 5, 2024

any update on that as the wrong type information still consists and so the logger is not behaving correctly

@ajimae ajimae merged commit 71dffbf into commercetools:master Jun 5, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants