Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): update dependency prettier to v3 #3137

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Jul 17, 2023

Mend Renovate

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
prettier (source) 2.8.8 -> 3.0.0 age adoption passing confidence

Release Notes

prettier/prettier (prettier)

v3.0.0

Compare Source

diff

πŸ”— Release Notes


Configuration

πŸ“… Schedule: Branch creation - "before 4am on Monday" (UTC), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

β™» Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

πŸ”• Ignore: Close this PR and you won't be reminded about these updates again.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by Mend Renovate. View repository job log here.

@renovate renovate bot added the πŸ€– Type: Dependencies Dependency updates or something similar label Jul 17, 2023
@changeset-bot
Copy link

changeset-bot bot commented Jul 17, 2023

πŸ¦‹ Changeset detected

Latest commit: fc80aa2

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 35 packages
Name Type
@commercetools-applications/merchant-center-template-starter-typescript Patch
@commercetools-backend/eslint-config-node Patch
@commercetools-frontend/application-components Patch
@commercetools-applications/merchant-center-template-starter Patch
@commercetools-frontend/eslint-config-mc-app Patch
@commercetools-frontend/create-mc-app Patch
@commercetools-frontend/mc-scripts Patch
@commercetools-frontend/codemod Patch
@commercetools-frontend/application-shell Patch
@commercetools-local/playground Patch
@commercetools-local/visual-testing-app Patch
@commercetools-website/components-playground Patch
@commercetools-frontend/cypress Patch
@commercetools-backend/express Patch
@commercetools-backend/loggers Patch
@commercetools-frontend/actions-global Patch
@commercetools-frontend/application-config Patch
@commercetools-frontend/application-shell-connectors Patch
@commercetools-frontend/assets Patch
@commercetools-frontend/babel-preset-mc-app Patch
@commercetools-frontend/browser-history Patch
@commercetools-frontend/constants Patch
@commercetools-frontend/i18n Patch
@commercetools-frontend/jest-preset-mc-app Patch
@commercetools-frontend/jest-stylelint-runner Patch
@commercetools-frontend/l10n Patch
@commercetools-frontend/mc-dev-authentication Patch
@commercetools-frontend/mc-html-template Patch
@commercetools-frontend/notifications Patch
@commercetools-frontend/permissions Patch
@commercetools-frontend/react-notifications Patch
@commercetools-frontend/sdk Patch
@commercetools-frontend/sentry Patch
@commercetools-frontend/url-utils Patch
@commercetools-website/custom-applications Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Jul 17, 2023

Deploy preview for merchant-center-application-kit ready!

βœ… Preview
https://merchant-center-application-hijt1z0lh-commercetools.vercel.app
https://appkit-sha-2d03a1111f86aa4054e42cbce811aadf061c3af5.commercetools.vercel.app
https://appkit-pr-3137.commercetools.vercel.app

Built with commit fc80aa2.
This pull request is being automatically deployed with vercel-action

@@ -33,11 +33,11 @@ function replaceEntryPointUriPathInConstants(
retainLines: true,
});
if (result?.code) {
const prettierConfig = prettier.resolveConfig.sync(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All this function are now async only.

@renovate
Copy link
Contributor Author

renovate bot commented Jul 31, 2023

Edited/Blocked Notification

Renovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR.

You can manually request rebase by checking the rebase/retry box above.

⚠️ Warning: custom changes will be lost.

@@ -11,7 +11,7 @@ import { addNotification } from '@commercetools-frontend/notifications';
import type { TShowNotification } from '../types';

export default function showNotification<
Notification extends TShowNotification
Notification extends TShowNotification,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems the latest version of prettier has the required trailing comma by default everywhere which makes this notation even for generics.

I tried to disable the default and go back to the previous one (es5) but I can't make it work.

Not sure if we want to keep the new styling rule (I personally don't like it for generics) or if we should avoid it.

@commercetools/shield-team-fe what do you think?

@CarlosCortizasCT
Copy link
Contributor

We're blocking this PR because an incompatibility between jest and the new prettier version.
This version changes some APIs to be async only and jest does not yet support it. This makes inline snapshots creation to fail.
We considered to disable prettier for this use case (example) but we decided to not going that path and just wait for jest to support the new prettier v3.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
πŸ›‘ Status: blocked πŸ€– Type: Dependencies Dependency updates or something similar
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant