-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(deps): update dependency prettier to v3 #3137
base: main
Are you sure you want to change the base?
Conversation
π¦ Changeset detectedLatest commit: fc80aa2 The changes in this PR will be included in the next version bump. This PR includes changesets to release 35 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Deploy preview for merchant-center-application-kit ready! β
Preview Built with commit fc80aa2. |
e24ecb5
to
8dcfb01
Compare
@@ -33,11 +33,11 @@ function replaceEntryPointUriPathInConstants( | |||
retainLines: true, | |||
}); | |||
if (result?.code) { | |||
const prettierConfig = prettier.resolveConfig.sync( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All this function are now async only.
Edited/Blocked NotificationRenovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR. You can manually request rebase by checking the rebase/retry box above. |
@@ -11,7 +11,7 @@ import { addNotification } from '@commercetools-frontend/notifications'; | |||
import type { TShowNotification } from '../types'; | |||
|
|||
export default function showNotification< | |||
Notification extends TShowNotification | |||
Notification extends TShowNotification, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems the latest version of prettier has the required trailing comma by default everywhere which makes this notation even for generics.
I tried to disable the default and go back to the previous one (es5
) but I can't make it work.
Not sure if we want to keep the new styling rule (I personally don't like it for generics) or if we should avoid it.
@commercetools/shield-team-fe what do you think?
We're blocking this PR because an incompatibility between |
This PR contains the following updates:
2.8.8
->3.0.0
Release Notes
prettier/prettier (prettier)
v3.0.0
Compare Source
diff
π Release Notes
Configuration
π Schedule: Branch creation - "before 4am on Monday" (UTC), Automerge - At any time (no schedule defined).
π¦ Automerge: Disabled by config. Please merge this manually once you are satisfied.
β» Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
π Ignore: Close this PR and you won't be reminded about these updates again.
This PR has been generated by Mend Renovate. View repository job log here.